diff options
| author | has2k1 | 2011-11-25 01:34:01 -0700 |
|---|---|---|
| committer | has2k1 | 2011-11-25 01:34:01 -0700 |
| commit | fde3ec31b85132323e5b463741baeaf295c23341 (patch) | |
| tree | 6e7f72da2ec9a312c38c0f77e3c904ef2930d423 | |
| parent | 96ea4c37a803e6336576ada46d25ab1be8390d15 (diff) | |
| download | vimium-fde3ec31b85132323e5b463741baeaf295c23341.tar.bz2 | |
Bugfix: Really hide bookmark dialog
Problem:
When bookmark completion is aborted using <ESC> key, the
completion dialog is faded out, zero opacity. This leaves
an invisible dialog hovering over the current page's content.
Any thing under the invisible dialog cannot get mouse focus,
including the links.
Solution:
After fading out the dialog, also hide it by its CSS display
property.
| -rw-r--r-- | completionDialog.js | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/completionDialog.js b/completionDialog.js index ff1991aa..2148de48 100644 --- a/completionDialog.js +++ b/completionDialog.js @@ -16,6 +16,7 @@ handlerStack.push({ keydown: this.onKeydown }); render.call(this); clearInterval(this._tweenId); + this.container.style.display = ""; this._tweenId = Tween.fade(this.container, 1.0, 150); } }, @@ -25,7 +26,11 @@ this.isShown=false; this.currentSelection=0; clearInterval(this._tweenId); - this._tweenId = Tween.fade(this.container, 0, 150); + var completionContainer = this.container; + var cssHide = function() { + completionContainer.style.display = "none"; + } + this._tweenId = Tween.fade(this.container, 0, 150, cssHide); } }, getDisplayElement: function() { |