From fde3ec31b85132323e5b463741baeaf295c23341 Mon Sep 17 00:00:00 2001 From: has2k1 Date: Fri, 25 Nov 2011 01:34:01 -0700 Subject: Bugfix: Really hide bookmark dialog Problem: When bookmark completion is aborted using key, the completion dialog is faded out, zero opacity. This leaves an invisible dialog hovering over the current page's content. Any thing under the invisible dialog cannot get mouse focus, including the links. Solution: After fading out the dialog, also hide it by its CSS display property. --- completionDialog.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/completionDialog.js b/completionDialog.js index ff1991aa..2148de48 100644 --- a/completionDialog.js +++ b/completionDialog.js @@ -16,6 +16,7 @@ handlerStack.push({ keydown: this.onKeydown }); render.call(this); clearInterval(this._tweenId); + this.container.style.display = ""; this._tweenId = Tween.fade(this.container, 1.0, 150); } }, @@ -25,7 +26,11 @@ this.isShown=false; this.currentSelection=0; clearInterval(this._tweenId); - this._tweenId = Tween.fade(this.container, 0, 150); + var completionContainer = this.container; + var cssHide = function() { + completionContainer.style.display = "none"; + } + this._tweenId = Tween.fade(this.container, 0, 150, cssHide); } }, getDisplayElement: function() { -- cgit v1.2.3