ComplianceCheckSet#update_status: Return result of `#update`

We should return the result of the `ActiveRecord` `#update` call, so
that we can determine if there was an error saving the
`ComplianceCheckSet` record.

Refs #4757

1 files changed, 3 insertions, 5 deletions

diff --git a/app/models/compliance_check_set.rb b/app/models/compliance_check_set.rb
index 062c5f4a4..d2155cb9a 100644
--- a/app/models/compliance_check_set.rb
+++ b/app/models/compliance_check_set.rb
@@ -22,18 +22,16 @@ class ComplianceCheckSet < ActiveRecord::Base
     statuses = compliance_check_resources.map do |resource|
       case resource.status
       when 'ERROR'
-        update(status: 'failed')
-        return
+        return update(status: 'failed')
       when 'WARNING'
-        update(status: 'warning')
-        return
+        return update(status: 'warning')
       else
         resource.status
       end
     end
 
     if all_statuses_are_ok(statuses)
-      update(status: 'successful')
+      return update(status: 'successful')
     end
   end