aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--app/models/compliance_check_set.rb8
-rw-r--r--spec/models/compliance_check_set_spec.rb3
2 files changed, 5 insertions, 6 deletions
diff --git a/app/models/compliance_check_set.rb b/app/models/compliance_check_set.rb
index 062c5f4a4..d2155cb9a 100644
--- a/app/models/compliance_check_set.rb
+++ b/app/models/compliance_check_set.rb
@@ -22,18 +22,16 @@ class ComplianceCheckSet < ActiveRecord::Base
statuses = compliance_check_resources.map do |resource|
case resource.status
when 'ERROR'
- update(status: 'failed')
- return
+ return update(status: 'failed')
when 'WARNING'
- update(status: 'warning')
- return
+ return update(status: 'warning')
else
resource.status
end
end
if all_statuses_are_ok(statuses)
- update(status: 'successful')
+ return update(status: 'successful')
end
end
diff --git a/spec/models/compliance_check_set_spec.rb b/spec/models/compliance_check_set_spec.rb
index 92b052b53..d3a5e941e 100644
--- a/spec/models/compliance_check_set_spec.rb
+++ b/spec/models/compliance_check_set_spec.rb
@@ -41,8 +41,9 @@ RSpec.describe ComplianceCheckSet, type: :model do
status: 'OK'
)
- check_set.update_status
+ updated = check_set.update_status
+ expect(updated).to be true
expect(check_set.status).to eq('failed')
end