aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorXu Cheng2015-02-25 14:13:36 +0800
committerXu Cheng2015-02-25 16:44:25 +0800
commitbe15a514ebf44d1cab0e3fce0ad0bd7039d0dec1 (patch)
treee873fb2a1fc79c0b84437d75cffe4b644a5e5aff /Library
parent747542352de66c014db0b2966585fa4b85d0fe6c (diff)
downloadbrew-be15a514ebf44d1cab0e3fce0ad0bd7039d0dec1.tar.bz2
audit: suggest setting JAVA_HOME by `depends_on :java`
Closes Homebrew/homebrew#37174. Signed-off-by: Xu Cheng <xucheng@me.com>
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cmd/audit.rb7
1 files changed, 7 insertions, 0 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index 3f1463194..d517b95e0 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -198,6 +198,12 @@ class FormulaAuditor
end
end
+ def audit_java_home
+ if text =~ /JAVA_HOME/i && !formula.requirements.map(&:class).include?(JavaDependency)
+ problem "Use `depends_on :java` to set JAVA_HOME"
+ end
+ end
+
def audit_conflicts
formula.conflicts.each do |c|
begin
@@ -760,6 +766,7 @@ class FormulaAuditor
audit_specs
audit_urls
audit_deps
+ audit_java_home
audit_conflicts
audit_options
audit_patches