From be15a514ebf44d1cab0e3fce0ad0bd7039d0dec1 Mon Sep 17 00:00:00 2001 From: Xu Cheng Date: Wed, 25 Feb 2015 14:13:36 +0800 Subject: audit: suggest setting JAVA_HOME by `depends_on :java` Closes Homebrew/homebrew#37174. Signed-off-by: Xu Cheng --- Library/Homebrew/cmd/audit.rb | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'Library') diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 3f1463194..d517b95e0 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -198,6 +198,12 @@ class FormulaAuditor end end + def audit_java_home + if text =~ /JAVA_HOME/i && !formula.requirements.map(&:class).include?(JavaDependency) + problem "Use `depends_on :java` to set JAVA_HOME" + end + end + def audit_conflicts formula.conflicts.each do |c| begin @@ -760,6 +766,7 @@ class FormulaAuditor audit_specs audit_urls audit_deps + audit_java_home audit_conflicts audit_options audit_patches -- cgit v1.2.3