aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/build.rb
diff options
context:
space:
mode:
authorJack Nagel2013-12-02 12:44:28 -0600
committerJack Nagel2013-12-02 12:47:50 -0600
commit69dcc2592ca58fec117b4a7fd78c72596af3ba50 (patch)
tree9e61b278ab4f6a08283da5359808f5634cfec8e5 /Library/Homebrew/build.rb
parentbcfafca56b86058c0cc5ac9d420c364206cb2110 (diff)
downloadbrew-69dcc2592ca58fec117b4a7fd78c72596af3ba50.tar.bz2
Don't mutate deps collection when expanding requirements
Fixes Homebrew/homebrew-science#213.
Diffstat (limited to 'Library/Homebrew/build.rb')
-rwxr-xr-xLibrary/Homebrew/build.rb6
1 files changed, 2 insertions, 4 deletions
diff --git a/Library/Homebrew/build.rb b/Library/Homebrew/build.rb
index e75a6841e..eb0677a59 100755
--- a/Library/Homebrew/build.rb
+++ b/Library/Homebrew/build.rb
@@ -61,10 +61,8 @@ class Build
def initialize(f)
@f = f
- # Expand requirements before dependencies, as requirements
- # may add dependencies if a default formula is activated.
- @reqs = expand_reqs
@deps = expand_deps
+ @reqs = expand_reqs
end
def post_superenv_hacks
@@ -88,7 +86,7 @@ class Build
elsif req.build? && dependent != f
Requirement.prune
elsif req.satisfied? && req.default_formula? && (dep = req.to_dependency).installed?
- dependent.deps << dep
+ deps << dep
Requirement.prune
end
end