From 69dcc2592ca58fec117b4a7fd78c72596af3ba50 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Mon, 2 Dec 2013 12:44:28 -0600 Subject: Don't mutate deps collection when expanding requirements Fixes Homebrew/homebrew-science#213. --- Library/Homebrew/build.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'Library/Homebrew/build.rb') diff --git a/Library/Homebrew/build.rb b/Library/Homebrew/build.rb index e75a6841e..eb0677a59 100755 --- a/Library/Homebrew/build.rb +++ b/Library/Homebrew/build.rb @@ -61,10 +61,8 @@ class Build def initialize(f) @f = f - # Expand requirements before dependencies, as requirements - # may add dependencies if a default formula is activated. - @reqs = expand_reqs @deps = expand_deps + @reqs = expand_reqs end def post_superenv_hacks @@ -88,7 +86,7 @@ class Build elsif req.build? && dependent != f Requirement.prune elsif req.satisfied? && req.default_formula? && (dep = req.to_dependency).installed? - dependent.deps << dep + deps << dep Requirement.prune end end -- cgit v1.2.3