diff options
| author | Teddy Wing | 2019-06-17 20:28:55 +0200 |
|---|---|---|
| committer | Teddy Wing | 2019-06-17 20:28:55 +0200 |
| commit | 0c7d7544107ca416654cc0dffc7f627da5f07797 (patch) | |
| tree | c4d1be2859c2d84106a3fb82591516e9af702405 | |
| parent | ccd5d657bf0550c269c2c3da4925c81fd71e420c (diff) | |
| download | code-review-0c7d7544107ca416654cc0dffc7f627da5f07797.tar.bz2 | |
code-review-difftool: Remove `extglob` `shopt` maneuvers
Turns out I don't need to worry about setting or unsetting `extglob` at
all because the script gets executed in a subshell. Obviously. Didn't
realise or test thoroughly at first.
| -rwxr-xr-x | code-review-difftool | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/code-review-difftool b/code-review-difftool index 10ff89d..9cbf631 100755 --- a/code-review-difftool +++ b/code-review-difftool @@ -24,15 +24,7 @@ source "$SCRIPT/code-review-database" review_base="$(get_merge_base)" # Remove dot ranges at the end of a revision as Fugitive doesn't support them. -shopt -p extglob -has_extglob=$? - -if [ $has_extglob -ne 0 ]; then - shopt -s extglob -fi +shopt -s extglob review_base_without_dots="${review_base%%?(..|...)}" -if [ $has_extglob -ne 0 ]; then - shopt -u extglob -fi vim -c "tabdo Gdiff $review_base_without_dots" -p $(code-review changed-files) |