From 0c7d7544107ca416654cc0dffc7f627da5f07797 Mon Sep 17 00:00:00 2001
From: Teddy Wing
Date: Mon, 17 Jun 2019 20:28:55 +0200
Subject: code-review-difftool: Remove `extglob` `shopt` maneuvers

Turns out I don't need to worry about setting or unsetting `extglob` at
all because the script gets executed in a subshell. Obviously. Didn't
realise or test thoroughly at first.
---
 code-review-difftool | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/code-review-difftool b/code-review-difftool
index 10ff89d..9cbf631 100755
--- a/code-review-difftool
+++ b/code-review-difftool
@@ -24,15 +24,7 @@ source "$SCRIPT/code-review-database"
 review_base="$(get_merge_base)"
 
 # Remove dot ranges at the end of a revision as Fugitive doesn't support them.
-shopt -p extglob
-has_extglob=$?
-
-if [ $has_extglob -ne 0 ]; then
-	shopt -s extglob
-fi
+shopt -s extglob
 review_base_without_dots="${review_base%%?(..|...)}"
-if [ $has_extglob -ne 0 ]; then
-	shopt -u extglob
-fi
 
 vim -c "tabdo Gdiff $review_base_without_dots" -p $(code-review changed-files)
-- 
cgit v1.2.3