App.java: Move `PdfReader`, `PdfWriter` declaration to `main`

Didn't make sense to have the `replacePdfFieldFont` function do things
related to command line argument parsing.

I had done it that way originally because that's how my mind worked out
the standard input and output handling at the time.

1 files changed, 15 insertions, 23 deletions

diff --git a/src/main/java/com/teddywing/pdf_form_replace_font2/App.java b/src/main/java/com/teddywing/pdf_form_replace_font2/App.java
index 9c0863b..1a67c4b 100644
--- a/src/main/java/com/teddywing/pdf_form_replace_font2/App.java
+++ b/src/main/java/com/teddywing/pdf_form_replace_font2/App.java
@@ -78,10 +78,14 @@ public class App {
 				System.exit(0);
 			}
 
-			String input = "-";
+			PdfReader reader;
 			String[] free_args = options_matches.getArgs();
-			if (free_args.length > 0) {
-				input = free_args[0];
+			if (free_args.length == 0) {
+				reader = new PdfReader(System.in);
+			}
+			else {
+				String input = free_args[0];
+				reader = new PdfReader(input);
 			}
 
 			String find = options_matches.getOptionValue("find");
@@ -96,12 +100,16 @@ public class App {
 				System.exit(64);
 			}
 
+			PdfWriter writer;
 			String output = options_matches.getOptionValue("output");
 			if (output == null) {
-				output = "-";
+				writer = new PdfWriter(System.out);
+			}
+			else {
+				writer = new PdfWriter(output);
 			}
 
-			App.replacePdfFieldFont(input, output, find, replace);
+			App.replacePdfFieldFont(reader, writer, find, replace);
 		}
 		catch (ParseException e) {
 			System.err.println("error: " + e.getMessage());
@@ -110,27 +118,11 @@ public class App {
 	}
 
 	private static void replacePdfFieldFont(
-		String input,
-		String output,
+		PdfReader reader,
+		PdfWriter writer,
 		String original_font_postscript_name,
 		String replacement_font_postscript_name
 	) throws IOException {
-		PdfReader reader;
-		if (input == "-") {
-			reader = new PdfReader(System.in);
-		}
-		else {
-			reader = new PdfReader(input);
-		}
-
-		PdfWriter writer;
-		if (output == "-") {
-			writer = new PdfWriter(System.out);
-		}
-		else {
-			writer = new PdfWriter(output);
-		}
-
 		PdfDocument pdf = new PdfDocument(reader, writer);
 
 		FontProgramFactory