blob: 0da2bb07e310fd6fd2bfdf2e21af0a2be255c799 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
|
package main
import "errors"
func shouldDeclareErrInSignature() error { // want "return signature should be '\\(err error\\)'"
var err error // Should use variable declared in signature
err = nil
if err != nil {
return err
}
defer func() {
err = errors.New("defer error")
}()
return nil // want "does not return 'err'"
}
func doesDeclareErrInSignature() (err error) {
err = nil
if err != nil {
return err
}
defer func() {
err = errors.New("defer error")
}()
return nil // want "does not return 'err'"
}
func returnedErrorMustMatchDeferErrorName() (err error) {
err = nil
if err != nil {
return err
}
defer func() {
err = errors.New("defer error")
}()
err2 := errors.New("returned error")
return err2 // want "does not return 'err'"
}
func deferUsesUnconventionalErrName() error { // want "return signature should be '\\(anErr error\\)'"
var anErr error
anErr = nil
if anErr != nil {
return anErr
}
defer func() {
anErr = errors.New("defer error")
}()
return anErr
}
// TODO: This is starting to look like needless complexity. Maybe we just
// report that the error variable must be declared in the signature instead.
func multipleReturnValuesString() (string, error) { // want "return signature should be '\\(string1 string, err error\\)'"
var err error = nil
if err != nil {
return "", err
}
defer func() {
err = errors.New("defer error")
}()
return "ret", err
}
type AStruct struct {}
func multipleReturnValuesStruct() (*AStruct, error) { // want "return signature should be '\\(aStruct1 *AStruct, err error\\)'"
var err error = nil
if err != nil {
return nil, err
}
defer func() {
err = errors.New("defer error")
}()
return &AStruct{}, err
}
func good() (err error) {
err = nil
if err != nil {
return err
}
defer func() {
err = errors.New("defer error")
}()
return err
}
func noErrorInReturn() string {
return "test"
}
|
