1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
|
// Copyright (c) 2023 Teddy Wing
//
// This file is part of Godefererr.
//
// Godefererr is free software: you can redistribute it and/or
// modify it under the terms of the GNU General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) any later version.
//
// Godefererr is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
// General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Godefererr. If not, see <https://www.gnu.org/licenses/>.
package main
import "errors"
func shouldDeclareErrInSignature() error { // want "return signature should use named error parameter err"
// Should use variable declared in signature. We don't need to report this
// as if the variable is declared in the signature, a redeclaration causes
// a compile error.
var err error
err = nil
if err != nil {
return err
}
defer func() {
err = errors.New("defer error")
}()
return nil // want "does not return 'err'"
}
func doesDeclareErrInSignature() (err error) {
err = nil
if err != nil {
return err
}
defer func() {
err = errors.New("defer error")
}()
return nil // want "does not return 'err'"
}
func returnedErrorMustMatchDeferErrorName() (err error) {
err = nil
if err != nil {
return err
}
defer func() {
err = errors.New("defer error")
}()
err2 := errors.New("returned error")
return err2 // want "does not return 'err'"
}
func deferUsesUnconventionalErrName() error { // want "return signature should use named error parameter anErr"
var anErr error
anErr = nil
if anErr != nil {
return anErr
}
defer func() {
anErr = errors.New("defer error")
}()
return anErr
}
func multipleReturnValuesString() (string, error) { // want "return signature should use named error parameter err"
var err error = nil
if err != nil {
return "", err
}
defer func() {
err = errors.New("defer error")
}()
return "ret", err
}
type AStruct struct {}
func multipleReturnValuesStructBool() (*AStruct, bool, error) { // want "return signature should use named error parameter err"
var err error = nil
if err != nil {
return nil, false, err
}
defer func() {
err = errors.New("defer error")
}()
return &AStruct{}, true, err
}
func good() (err error) {
err = nil
if err != nil {
return err
}
defer func() {
err = errors.New("defer error")
}()
return err
}
func noErrorInReturn() string {
return "test"
}
|
