1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
|
// TODO: doc
package defererr
import (
"fmt"
"go/ast"
"golang.org/x/tools/go/analysis"
)
var Analyzer = &analysis.Analyzer{
Name: "defererr",
Doc: "reports issues returning errors from defer",
Run: run,
}
func run(pass *analysis.Pass) (interface{}, error) {
// TODO: Find defer closure
// Does it set error defined in outer scope?
// Does outer scope declare error variable in signature?
// Is err variable returned after closure?
for _, file := range pass.Files {
ast.Inspect(
file,
func(node ast.Node) bool {
funcDecl, ok := node.(*ast.FuncDecl)
if !ok {
return true
}
if funcDecl.Type.Results == nil {
return true
}
funcReturnsError := false
for _, returnVal := range funcDecl.Type.Results.List {
fmt.Printf("returnVal: %#v\n", returnVal.Type)
returnIdent, ok := returnVal.Type.(*ast.Ident)
if !ok {
return true
}
if returnIdent.Name == "error" {
funcReturnsError = true
}
}
// Can we do the same for non-error types?
// for _, returnVal := range funcType.Results.List {
// }
if !funcReturnsError {
return true
}
ast.Inspect(
funcDecl.Body,
func(node ast.Node) bool {
// fmt.Printf("node: %#v\n", node)
deferStmt, ok := node.(*ast.DeferStmt)
if !ok {
return true
}
fmt.Printf("defer: %#v\n", deferStmt)
// TODO: Find out if defer uses assigns an error variable without declaring it
return true
},
)
// // Look for a function literal after the `defer` statement.
// funcLit, ok := deferStmt.Call.Fun.(*ast.FuncLit)
// if !ok {
// return true
// }
//
// funcScope := pass.TypesInfo.Scopes[funcLit.Type]
//
// // Try to find the function where the defer is defined. Note, defer can be defined in an inner block.
// funcType, ok := funcScope.Parent().(*ast.FuncType)
// if !ok {
// return true
// }
// fmt.Printf("func: %#v\n", funcType)
//
// if funcLit.Type.Results == nil {
// return true
// }
//
// for _, returnVal := range funcLit.Type.Results.List {
// fmt.Printf("returnVal: %#v\n", returnVal)
// }
return true
},
)
}
return nil, nil
}
|
