aboutsummaryrefslogtreecommitdiffstats
path: root/defererr.go
diff options
context:
space:
mode:
authorTeddy Wing2023-05-21 01:14:42 +0200
committerTeddy Wing2023-05-21 01:14:42 +0200
commit30d84ab39810f837df184eee9632b7cce0d65308 (patch)
tree8b8ca007f9afb2e1d5b837a0f61de486055d7f81 /defererr.go
parenta7d7125608b4a823aa377be9cc11c6078628fb39 (diff)
downloadgodefererr-30d84ab39810f837df184eee9632b7cce0d65308.tar.bz2
Move error variable GenDecl check to function
Give the check a name.
Diffstat (limited to 'defererr.go')
-rw-r--r--defererr.go13
1 files changed, 10 insertions, 3 deletions
diff --git a/defererr.go b/defererr.go
index 71a9d15..5615463 100644
--- a/defererr.go
+++ b/defererr.go
@@ -185,9 +185,7 @@ func checkErrorAssignedInDefer(
// TODO: Was error lhs declared in defer closure? Then it
// should be ignored.
- if deferFuncLit.Body.Lbrace < valueSpec.Pos() &&
- valueSpec.Pos() < deferFuncLit.Body.Rbrace {
-
+ if isVariableDeclaredInsideDeferClosure(deferFuncLit, valueSpec) {
continue
}
@@ -244,3 +242,12 @@ func checkErrorAssignedInDefer(
},
)
}
+
+// TODO: doc
+func isVariableDeclaredInsideDeferClosure(
+ deferFuncLit *ast.FuncLit,
+ variableDecl *ast.ValueSpec,
+) bool {
+ return deferFuncLit.Body.Lbrace < variableDecl.Pos() &&
+ variableDecl.Pos() < deferFuncLit.Body.Rbrace
+}