aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorStephen Blott2015-06-01 12:26:16 +0100
committerStephen Blott2015-06-01 12:26:18 +0100
commitf50d3add7e6c95a5fc2945e067a52634a19c8a65 (patch)
treeb1dfb4c477849e68eec92aee3610a1758e79b77e /lib
parent971b2fbd6b45ff701ed2dc61fadfb4e7a2f20193 (diff)
downloadvimium-f50d3add7e6c95a5fc2945e067a52634a19c8a65.tar.bz2
Note bug in settings.
(This bug has been around for quite some time. I just noticed it now.)
Diffstat (limited to 'lib')
-rw-r--r--lib/settings.coffee2
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/settings.coffee b/lib/settings.coffee
index ca41ced7..343f782a 100644
--- a/lib/settings.coffee
+++ b/lib/settings.coffee
@@ -55,6 +55,8 @@ Settings =
set: (key, value) ->
# Don't store the value if it is equal to the default, so we can change the defaults in the future.
+ # FIXME(smblott). This test is broken for exclusionRules (for which it is never true). In this case, we
+ # need some kind of structural equality (or perhaps comparison of JSONified strings).
if value == @defaults[key]
@clear key
else