From f50d3add7e6c95a5fc2945e067a52634a19c8a65 Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Mon, 1 Jun 2015 12:26:16 +0100 Subject: Note bug in settings. (This bug has been around for quite some time. I just noticed it now.) --- lib/settings.coffee | 2 ++ 1 file changed, 2 insertions(+) (limited to 'lib') diff --git a/lib/settings.coffee b/lib/settings.coffee index ca41ced7..343f782a 100644 --- a/lib/settings.coffee +++ b/lib/settings.coffee @@ -55,6 +55,8 @@ Settings = set: (key, value) -> # Don't store the value if it is equal to the default, so we can change the defaults in the future. + # FIXME(smblott). This test is broken for exclusionRules (for which it is never true). In this case, we + # need some kind of structural equality (or perhaps comparison of JSONified strings). if value == @defaults[key] @clear key else -- cgit v1.2.3