diff options
| author | Stephen Blott | 2017-05-01 07:01:18 +0100 |
|---|---|---|
| committer | GitHub | 2017-05-01 07:01:18 +0100 |
| commit | 8a74fd31f3086538cfad50df30e0e2c87cd0a6cc (patch) | |
| tree | 53cbbfa95ca8acf69f6c5c80737ec4803b76d659 /lib/settings.coffee | |
| parent | c3b16da8391f4c37c79611f79f0ecadaa7b3b300 (diff) | |
| parent | 9a1b56a899575d71e07eb3466e5fbf16d5a18571 (diff) | |
| download | vimium-8a74fd31f3086538cfad50df30e0e2c87cd0a6cc.tar.bz2 | |
Merge pull request #2500 from mrmr1993/ff-fix-exclusions
FF - Fix "Save Changes" from the exclusions popup
Diffstat (limited to 'lib/settings.coffee')
| -rw-r--r-- | lib/settings.coffee | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/settings.coffee b/lib/settings.coffee index 9fa27c5f..08986723 100644 --- a/lib/settings.coffee +++ b/lib/settings.coffee @@ -89,6 +89,9 @@ Settings = # Remove options installed by the "copyNonDefaultsToChromeStorage-20150717" migration; see below. @log " chrome.storage.local.remove(#{key})" chrome.storage.local.remove key + # NOTE(mrmr1993): In FF, |value| will be garbage collected when the page owning it is unloaded. + # Any postUpdateHooks that can be called from the options page/exclusions popup should be careful not to + # use |value| asynchronously, or else it may refer to a |DeadObject| and accesses will throw an error. @performPostUpdateHook key, value clear: (key) -> |