diff options
| author | Stephen Blott | 2016-04-16 16:54:12 +0100 |
|---|---|---|
| committer | Stephen Blott | 2016-04-16 17:01:38 +0100 |
| commit | e07a252508eea45c4dcadc92cdad02d42df2f5f8 (patch) | |
| tree | 41cb4c9a3302aebf7bd03a4db4d874da24b0f79c /content_scripts | |
| parent | ae1a54157291c0bcc69a6e8652bc15e69b72b4e4 (diff) | |
| download | vimium-e07a252508eea45c4dcadc92cdad02d42df2f5f8.tar.bz2 | |
Minor code review.
Diffstat (limited to 'content_scripts')
| -rw-r--r-- | content_scripts/ui_component.coffee | 4 | ||||
| -rw-r--r-- | content_scripts/vimium_frontend.coffee | 2 | ||||
| -rw-r--r-- | content_scripts/vomnibar.coffee | 4 |
3 files changed, 3 insertions, 7 deletions
diff --git a/content_scripts/ui_component.coffee b/content_scripts/ui_component.coffee index 6aa22119..7792bfba 100644 --- a/content_scripts/ui_component.coffee +++ b/content_scripts/ui_component.coffee @@ -95,8 +95,7 @@ class UIComponent else window.focus() @options = null - # Inform the UI component that it is hidden. - @postMessage "hidden" + @postMessage "hidden" # Inform the UI component that it is hidden. # Fetch a Vimium file/resource (such as "content_scripts/vimium.css"). # We try making an XMLHttpRequest request. That can fail (see #1817), in which case we fetch the @@ -119,6 +118,5 @@ class UIComponent request.open "GET", (chrome.runtime.getURL file), true request.send() - root = exports ? window root.UIComponent = UIComponent diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index 56f7742e..986fd322 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -121,7 +121,7 @@ class NormalMode extends KeyHandlerMode if registryEntry.topFrame # The Vomnibar (a top-frame command) cannot coexist with the help dialog (it causes focus issues). - sourceFrameId = if HelpDialog.isShowing() and window.isVimiumUIComponent then 0 else frameId + sourceFrameId = if window.isVimiumUIComponent then 0 else frameId HelpDialog.toggle() if HelpDialog.isShowing() chrome.runtime.sendMessage handler: "sendMessageToFrames", message: {name: "runInTopFrame", sourceFrameId, registryEntry} diff --git a/content_scripts/vomnibar.coffee b/content_scripts/vomnibar.coffee index 646fda43..02ce97c5 100644 --- a/content_scripts/vomnibar.coffee +++ b/content_scripts/vomnibar.coffee @@ -49,9 +49,7 @@ Vomnibar = init: -> unless @vomnibarUI? - @vomnibarUI = new UIComponent "pages/vomnibar.html", "vomnibarFrame", (event) => - @vomnibarUI.hide() if event.data == "hide" - + @vomnibarUI = new UIComponent "pages/vomnibar.html", "vomnibarFrame", -> # This function opens the vomnibar. It accepts options, a map with the values: # completer - The completer to fetch results from. |