aboutsummaryrefslogtreecommitdiffstats
path: root/content_scripts
diff options
context:
space:
mode:
authormrmr19932017-05-01 00:15:51 +0100
committermrmr19932017-05-01 00:15:51 +0100
commit9a1b56a899575d71e07eb3466e5fbf16d5a18571 (patch)
tree53cbbfa95ca8acf69f6c5c80737ec4803b76d659 /content_scripts
parentc3b16da8391f4c37c79611f79f0ecadaa7b3b300 (diff)
downloadvimium-9a1b56a899575d71e07eb3466e5fbf16d5a18571.tar.bz2
FF - Fix updates from the exclusions popup
This stops |Exclusions| from holding a reference to the |value| parameter passed to |Settings.set|. In Firefox, this object is garbage collected when the owning context (the exclusions popup) is closed. The fix for all such cases in the future is to switch to using |Settings.get|, which implicitly does |JSON.parse JSON.stringify value| and thus returns an object in the same context as |Settings|. We could fix this generally by doing this for the |Settings.performPostUpdateHook| call in |Settings.set| instead. However, I'm not convinced that it warrants the overhead of a |JSON.parse| for every |Settings.set| call.
Diffstat (limited to 'content_scripts')
0 files changed, 0 insertions, 0 deletions