diff options
| author | Stephen Blott | 2016-01-31 16:35:26 +0000 |
|---|---|---|
| committer | Stephen Blott | 2016-01-31 16:35:26 +0000 |
| commit | 63e2387853d69b39454e71ec8006d2b512e86248 (patch) | |
| tree | 80c902e617ff950b8c7ec926e0d692f9647dce08 /content_scripts | |
| parent | b14082d0021830c5359e7fc5f81175941e9319ad (diff) | |
| download | vimium-63e2387853d69b39454e71ec8006d2b512e86248.tar.bz2 | |
Fix visual indicator for `focusInput()`.
Currently, if an input is only partially in the view port, then the page
may scroll when it is focused and the overlays for `focusInput()` are
wonky. See #1257.
Here, we draw the overlay around the *entire* input, instead of just
around the visible part. Being partially visible therefore is no longer
relevant.
Fixes #1257.
Closes #1258.
Diffstat (limited to 'content_scripts')
| -rw-r--r-- | content_scripts/vimium_frontend.coffee | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index 145a7508..f596ccf7 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -385,9 +385,8 @@ extend window, visibleInputs = for i in [0...resultSet.snapshotLength] by 1 element = resultSet.snapshotItem i - rect = DomUtils.getVisibleClientRect element, true - continue if rect == null - { element: element, rect: rect } + continue unless DomUtils.getVisibleClientRect element, true + { element, rect: DomUtils.getBoundingClientRect element } if visibleInputs.length == 0 HUD.showForDuration("There are no inputs to focus.", 1000) |