diff options
| author | Matt Garriott | 2012-09-03 13:57:07 -0600 |
|---|---|---|
| committer | Matt Garriott | 2012-09-03 14:07:42 -0600 |
| commit | 61ae9a0c69ce716a15e9347413441cc257e18faa (patch) | |
| tree | d0b9a9c896b7a2e48d2b21890f4d49dd7c4b6843 /content_scripts | |
| parent | b7ea67d458c996de56b44551554600bf05faebe2 (diff) | |
| download | vimium-61ae9a0c69ce716a15e9347413441cc257e18faa.tar.bz2 | |
The help dialog now gets showAdvancedCommands directly from settings.
Diffstat (limited to 'content_scripts')
| -rw-r--r-- | content_scripts/vimium_frontend.coffee | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index 54a3bb2e..034c241b 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -43,7 +43,7 @@ settings = values: {} loadedValues: 0 valuesToLoad: ["scrollStepSize", "linkHintCharacters", "filterLinkHints", "hideHud", "previousPatterns", - "nextPatterns", "findModeRawQuery", "userDefinedLinkHintCss"] + "nextPatterns", "findModeRawQuery", "userDefinedLinkHintCss", "helpDialog_showAdvancedCommands"] isLoaded: false eventListeners: {} @@ -883,24 +883,23 @@ window.showHelpDialog = (html, fid) -> VimiumHelpDialog = # This setting is pulled out of local storage. It's false by default. - getShowAdvancedCommands: (callback) -> - chrome.extension.sendRequest({ handler: "getShowAdvancedCommands"}, callback) + getShowAdvancedCommands: -> settings.get("helpDialog_showAdvancedCommands") init: () -> this.dialogElement = document.getElementById("vimiumHelpDialog") this.dialogElement.getElementsByClassName("toggleAdvancedCommands")[0].addEventListener("click", VimiumHelpDialog.toggleAdvancedCommands, false) this.dialogElement.style.maxHeight = window.innerHeight - 80 - this.getShowAdvancedCommands(this.showAdvancedCommands) + this.showAdvancedCommands(this.getShowAdvancedCommands()) # # Advanced commands are hidden by default so they don't overwhelm new and casual users. # toggleAdvancedCommands: (event) -> event.preventDefault() - VimiumHelpDialog.getShowAdvancedCommands((value) -> - VimiumHelpDialog.showAdvancedCommands(!value) - chrome.extension.sendRequest({ handler: "saveHelpDialogSettings", showAdvancedCommands: !value })) + showAdvanced = VimiumHelpDialog.getShowAdvancedCommands() + VimiumHelpDialog.showAdvancedCommands(!showAdvanced) + settings.set("helpDialog_showAdvancedCommands", !showAdvanced) showAdvancedCommands: (visible) -> VimiumHelpDialog.dialogElement.getElementsByClassName("toggleAdvancedCommands")[0].innerHTML = |