diff options
| author | Stephen Blott | 2016-12-11 14:18:59 +0000 |
|---|---|---|
| committer | Stephen Blott | 2016-12-11 14:52:21 +0000 |
| commit | cc09af6921228033b822ef4ad4713abd26c375e7 (patch) | |
| tree | f75eb8c6a6108897571b2c1884b4f39e5382a55a /content_scripts/vimium_frontend.coffee | |
| parent | 1664a02c02be27a824b19633740a23ec01573c77 (diff) | |
| download | vimium-cc09af6921228033b822ef4ad4713abd26c375e7.tar.bz2 | |
Rework help-dialog HTML.
Previously, the dynamic HTML for the help dialog was generated on the
background page. The HTML itself was tangled in with program logic.
Here, we move all of the HTML to HTML5 templates; also, we build the
help-dialog contents in the help dialog itself, not on the background
page.
Note: #2368 is included here too.
(Background: I'm trying to clean up some of the command and help-dialog
logic in preparation for addressing the issue of how to document command
options, see #2319.)
Diffstat (limited to 'content_scripts/vimium_frontend.coffee')
| -rw-r--r-- | content_scripts/vimium_frontend.coffee | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index fcca98ab..21826944 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -646,8 +646,7 @@ enterFindMode = -> new FindMode() window.showHelp = (sourceFrameId) -> - chrome.runtime.sendMessage handler: "getHelpDialogHtml", (response) -> - HelpDialog.toggle {sourceFrameId, html: response} + HelpDialog.toggle {sourceFrameId, showAllCommandDetails: false} # If we are in the help dialog iframe, then HelpDialog is already defined with the necessary functions. window.HelpDialog ?= |