diff options
| author | Stephen Blott | 2016-04-18 11:43:53 +0100 |
|---|---|---|
| committer | Stephen Blott | 2016-04-18 12:20:32 +0100 |
| commit | 247878a7919c5e9b27638395d479939f9ad5d22e (patch) | |
| tree | 0416c617b5949a7b3c89938036ee735c222576b9 /content_scripts/ui_component.coffee | |
| parent | dd07ffaa15efc6dff138cdaf89a146f229cc5b9d (diff) | |
| download | vimium-247878a7919c5e9b27638395d479939f9ad5d22e.tar.bz2 | |
Cache content_scripts/vimium.css in chrome.storage.local.
Previously, we had two different approaches. This seems like a simpler
approach.
We simply cache the Vimium CSS in chrome.storage.local (in the
background page) and fetch it from there (in UI components).
There is also a minor change in the we no longer cache the CSS in
memory. This seems to be the right thing to do. Caching the CSS in
memory consumes a small amount of memory. However, it can only speed up
the fastest loads. It cannot speed up the first load -- which is likely
the one that matters most. So caching the CSS in memory seems to make
little sense.
Diffstat (limited to 'content_scripts/ui_component.coffee')
| -rw-r--r-- | content_scripts/ui_component.coffee | 29 |
1 files changed, 3 insertions, 26 deletions
diff --git a/content_scripts/ui_component.coffee b/content_scripts/ui_component.coffee index 1a7a1634..7422aada 100644 --- a/content_scripts/ui_component.coffee +++ b/content_scripts/ui_component.coffee @@ -5,7 +5,6 @@ class UIComponent iframeFrameId: null options: null shadowDOM: null - styleSheetGetter: null toggleIframeElementClasses: (removeClass, addClass) -> @iframeElement.classList.remove removeClass @@ -18,10 +17,9 @@ class UIComponent # Default to everything hidden while the stylesheet loads. styleSheet.innerHTML = "iframe {display: none;}" - # Use an XMLHttpRequest, possibly via the background page, to fetch the stylesheet. This allows us to - # catch and recover from failures that we could not have caught when using CSS @include (eg. #1817). - UIComponent::styleSheetGetter ?= new AsyncDataFetcher @fetchFileContents "content_scripts/vimium.css" - @styleSheetGetter.use (styles) -> styleSheet.innerHTML = styles + # Fetch "content_scripts/vimium.css" from chrome.storage.local; the background page caches it there. + chrome.storage.local.get "vimiumCSSInChromeStorage", (items) -> + styleSheet.innerHTML = items.vimiumCSSInChromeStorage @iframeElement = DomUtils.createElement "iframe" extend @iframeElement, @@ -99,26 +97,5 @@ class UIComponent @options = null @postMessage "hidden" # Inform the UI component that it is hidden. - # Fetch a Vimium file/resource (such as "content_scripts/vimium.css"). - # We try making an XMLHttpRequest request. That can fail (see #1817), in which case we fetch the - # file/resource via the background page. - fetchFileContents: (file) -> (callback) -> - request = new XMLHttpRequest() - - request.onload = -> - if request.status == 200 - callback request.responseText - else - request.onerror() - - request.onerror = -> - chrome.runtime.sendMessage - handler: "fetchFileContents" - fileName: file - , callback - - request.open "GET", (chrome.runtime.getURL file), true - request.send() - root = exports ? window root.UIComponent = UIComponent |