diff options
| author | Stephen Blott | 2017-12-14 14:08:35 +0000 |
|---|---|---|
| committer | Stephen Blott | 2017-12-14 14:12:08 +0000 |
| commit | f2d7e185c704e3cf8f6ca0c9d3d4da2498610475 (patch) | |
| tree | 965411d361a2c3405d94015a3b8dc9aab6225ca8 /content_scripts/link_hints.coffee | |
| parent | 797e25231b306403167f5a3f90d6cea6d9ba6dda (diff) | |
| download | vimium-f2d7e185c704e3cf8f6ca0c9d3d4da2498610475.tar.bz2 | |
Detect click listeners for link hints.
This is a simpler version of #1167. It detects clickable elements with
listeners added with `addEventListener()`.
It includes some of @mrmr1993's ideas from #1167 (in fact, it's mostly
those ideas tweaked into a slightly different form).
Diffstat (limited to 'content_scripts/link_hints.coffee')
| -rw-r--r-- | content_scripts/link_hints.coffee | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee index 0592c96d..e5c6b3ea 100644 --- a/content_scripts/link_hints.coffee +++ b/content_scripts/link_hints.coffee @@ -706,6 +706,9 @@ LocalHints = isClickable = true reason = "Open." + # Detect elements with "click" listeners installed with `addEventListener()`. + isClickable ||= element.hasAttribute vimiumOnClickAttributeName + # An element with a class name containing the text "button" might be clickable. However, real clickables # are often wrapped in elements with such class names. So, when we find clickables based only on their # class name, we mark them as unreliable. |
