Add migration code for old localStorage values.

Finish up the wrapping of localStorage. All background code should now
modify localStorage via settings.js rather than doing it directly.

1 files changed, 15 insertions, 0 deletions

diff --git a/background/settings.js b/background/settings.js
index 4792429d..51ac053c 100644
--- a/background/settings.js
+++ b/background/settings.js
@@ -35,6 +35,19 @@ var settings = {
     nextPatterns: "next,more,>,\u2192,\xbb,\u226b,>>",
   },
 
+  init: function() {
+    // settingsVersion was introduced in v1.31, and is used to coordinate data migration. We do not use
+    // previousVersion as it is used to coordinate the display of the upgrade message, and is not updated
+    // early enough when the extension loads.
+    // 1.31 was also the version where we converted all localStorage values to JSON.
+    if (!this.has("settingsVersion")) {
+      for (var key in localStorage) {
+        localStorage[key] = JSON.stringify(localStorage[key]);
+      }
+      this.set("settingsVersion", utils.getCurrentVersion());
+    }
+  },
+
   get: function(key) {
     if (!(key in localStorage))
       return this.defaultSettings[key];
@@ -59,3 +72,5 @@ var settings = {
   },
 
 };
+
+settings.init();