diff options
| author | Sudarshan Wadkar | 2015-02-26 23:13:07 -0500 |
|---|---|---|
| committer | Sudarshan Wadkar | 2015-02-26 23:18:15 -0500 |
| commit | e2e311fd8e422ec9de50a92566ff14a2a76fe74f (patch) | |
| tree | d4150eaaaa560aef98ed603c49bcff74849b9592 | |
| parent | 6be1188dd75891d903f74b814a127878190cad59 (diff) | |
| download | vimium-e2e311fd8e422ec9de50a92566ff14a2a76fe74f.tar.bz2 | |
Remove noise, explain in commit
- Change openUrlInNewTab to pass tab.windowId
Why? Work around for upstream bug #308171
- Change createTab to use openUrlInNewTab
Why? Fix issue #1507 to open new tab in current window
(Note: This commit removes noise from the code and explains the changes)
| -rw-r--r-- | background_scripts/main.coffee | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/background_scripts/main.coffee b/background_scripts/main.coffee index 72b36b0b..a7dbeca8 100644 --- a/background_scripts/main.coffee +++ b/background_scripts/main.coffee @@ -165,8 +165,6 @@ openUrlInCurrentTab = (request) -> # openUrlInNewTab = (request) -> chrome.tabs.getSelected(null, (tab) -> - # Pass selected tabs windowId to make sure we open in current window. - # Fixes issue #1507 Open new tab in incognito mode should open new tab in same window. chrome.tabs.create({ url: Utils.convertToUrl(request.url), index: tab.index + 1, selected: true, windowId: tab.windowId })) openUrlInIncognito = (request) -> @@ -233,9 +231,6 @@ moveTab = (callback, direction) -> # These are commands which are bound to keystroke which must be handled by the background page. They are # mapped in commands.coffee. BackgroundCommands = - # Using openUrlInNewTab instead of chrome.tabs.create() because of upstread bug #308171. - # The function openUrlInNewTab now selects the current tab and uses its windowId while - # opening a new tab to force proper window selection. createTab: (callback) -> openUrlInNewTab({ url: Settings.get("newTabUrl") }) duplicateTab: (callback) -> chrome.tabs.getSelected(null, (tab) -> |