aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Blott2015-03-07 16:49:32 +0000
committerStephen Blott2015-03-07 16:58:02 +0000
commitb05276ed8264e5a71f20a7068690ba2a414ee6d8 (patch)
tree9c96d165dd536f696a1f0e5638ba9ca5f4c34cb1
parentae60abb94665446200db8a750bbc1362895d04d2 (diff)
downloadvimium-b05276ed8264e5a71f20a7068690ba2a414ee6d8.tar.bz2
Reload content scripts after install/update.
This is @mrmr1993's work from #1041. Reload content scripts when vimium is installed or updates. (@mrmr1993: The automatic merge was really messy (or, at least, I couldn't figure out what was going on). Since the bulk of #1041 was actually quite compact, I took the liberty of just copying it in. Hope you don't mind.)
-rw-r--r--background_scripts/main.coffee19
-rw-r--r--content_scripts/vimium_frontend.coffee3
-rw-r--r--tests/dom_tests/dom_tests.coffee4
-rw-r--r--tests/unit_tests/test_chrome_stubs.coffee2
4 files changed, 25 insertions, 3 deletions
diff --git a/background_scripts/main.coffee b/background_scripts/main.coffee
index 23950e6e..7b360efd 100644
--- a/background_scripts/main.coffee
+++ b/background_scripts/main.coffee
@@ -2,6 +2,25 @@ root = exports ? window
currentVersion = Utils.getCurrentVersion()
+# Iterate over existing tabs and inject the necessary javascript/css into each.
+injectContentScriptsIntoOpenTabs = ->
+ manifest = chrome.runtime.getManifest()
+ # Content scripts loaded on every page should be in the same group. We assume it is the first.
+ contentScripts = manifest.content_scripts[0]
+ chrome.tabs.query { status: "complete" }, (tabs) ->
+ jobs = [ [ chrome.tabs.executeScript, contentScripts.js ], [ chrome.tabs.insertCSS, contentScripts.css ] ]
+ # Chrome complains if we don't evaluate chrome.runtime.lastError on errors (and we get errors for tabs on
+ # which Vimium cannot run).
+ checkLastRuntimeError = -> chrome.runtime.lastError
+ for tab in tabs
+ for [ func, files ] in jobs
+ for file in files
+ func tab.id, { file: file, allFrames: contentScripts.allFrames }, checkLastRuntimeError
+
+# The browser may have tabs already open. We inject the content scripts immediately so that they work straight
+# away.
+chrome.runtime.onInstalled.addListener injectContentScriptsIntoOpenTabs
+
tabQueue = {} # windowId -> Array
tabInfoMap = {} # tabId -> object with various tab properties
keyQueue = "" # Queue of keys typed
diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee
index b2d9f735..66922084 100644
--- a/content_scripts/vimium_frontend.coffee
+++ b/content_scripts/vimium_frontend.coffee
@@ -210,6 +210,7 @@ window.initializeWhenEnabled = ->
for type in [ "keydown", "keypress", "keyup", "click", "focus", "blur", "mousedown" ]
do (type) -> installListener window, type, (event) -> handlerStack.bubbleEvent type, event
installListener document, "DOMActivate", (event) -> handlerStack.bubbleEvent 'DOMActivate', event
+ installListener document, "focus", detectFocus
installedListeners = true
FindModeHistory.init()
@@ -229,7 +230,7 @@ getActiveState = ->
#
# The backend needs to know which frame has focus.
#
-window.addEventListener "focus", ->
+detectFocus = ->
# settings may have changed since the frame last had focus
settings.load()
chrome.runtime.sendMessage({ handler: "frameFocused", frameId: frameId })
diff --git a/tests/dom_tests/dom_tests.coffee b/tests/dom_tests/dom_tests.coffee
index 600616a9..ff95d3f4 100644
--- a/tests/dom_tests/dom_tests.coffee
+++ b/tests/dom_tests/dom_tests.coffee
@@ -542,7 +542,7 @@ context "Mode badges",
should "have an I badge in insert mode by focus", ->
document.getElementById("first").focus()
- assert.isTrue chromeMessages[0].badge == "I"
+ assert.isTrue chromeMessages[1].badge == "I"
should "have no badge after leaving insert mode by focus", ->
document.getElementById("first").focus()
@@ -575,5 +575,5 @@ context "Mode badges",
passKeys: ""
document.getElementById("first").focus()
- assert.isTrue chromeMessages[0].badge == ""
+ assert.isTrue chromeMessages[1].badge == ""
diff --git a/tests/unit_tests/test_chrome_stubs.coffee b/tests/unit_tests/test_chrome_stubs.coffee
index c61d7246..bc50521a 100644
--- a/tests/unit_tests/test_chrome_stubs.coffee
+++ b/tests/unit_tests/test_chrome_stubs.coffee
@@ -16,6 +16,8 @@ exports.chrome =
addListener: () -> true
onMessage:
addListener: () -> true
+ onInstalled:
+ addListener: ->
tabs:
onSelectionChanged: