aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Blott2014-11-06 15:23:25 +0000
committerStephen Blott2014-11-06 15:23:25 +0000
commit8e4e95c87d2ea06fcc0d9d354a180dfa1f31cdd2 (patch)
treec16c496d67905786871a85cdf7aeb63946f3b8d1
parent9be92a96816839a812decda48be81f3100a86e0f (diff)
downloadvimium-8e4e95c87d2ea06fcc0d9d354a180dfa1f31cdd2.tar.bz2
Prune unnecessary stuff in ensureScrollChange.
-rw-r--r--content_scripts/scroller.coffee7
1 files changed, 3 insertions, 4 deletions
diff --git a/content_scripts/scroller.coffee b/content_scripts/scroller.coffee
index 8eb50d77..b3a14c78 100644
--- a/content_scripts/scroller.coffee
+++ b/content_scripts/scroller.coffee
@@ -38,11 +38,10 @@ ensureScrollChange = (direction, changeFn) ->
element = activatedElement
loop
oldScrollValue = element[axisName]
- overflow = window.getComputedStyle(element, null).getPropertyValue("overflow-#{direction}")
- # Elements with `overflow: hidden` don't natively have scrolling, so we shouldn't scroll them.
+ # Elements with `overflow: hidden` should not be scrolled.
+ overflow = window.getComputedStyle(element).getPropertyValue("overflow-#{direction}")
changeFn(element, axisName) unless overflow == "hidden"
- break unless (element[axisName] == oldScrollValue && element != document.body)
- lastElement = element
+ break unless element[axisName] == oldScrollValue && element != document.body
# we may have an orphaned element. if so, just scroll the body element.
element = element.parentElement || document.body