aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Blott2014-12-15 08:46:00 +0000
committerStephen Blott2014-12-15 08:46:00 +0000
commit82f8ccd6a8376aa854f21bf13d3649f548422fdf (patch)
treea30cc0c306000f39a652c17401c93434b09d3355
parent8b954d68b1d52031fbddae16dd4c56d504daf9f6 (diff)
downloadvimium-82f8ccd6a8376aa854f21bf13d3649f548422fdf.tar.bz2
Fix second memory leak in KeydownEvents.
-rw-r--r--content_scripts/vimium_frontend.coffee5
1 files changed, 2 insertions, 3 deletions
diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee
index 0385f99b..16783bda 100644
--- a/content_scripts/vimium_frontend.coffee
+++ b/content_scripts/vimium_frontend.coffee
@@ -361,11 +361,9 @@ KeydownEvents =
# Yields truthy or falsy depending upon whether a corresponding keydown event is present (and removes that
# event).
pop: (event) ->
- console.log @handledEvents
detailString = @stringify event
value = @handledEvents[detailString]
delete @handledEvents[detailString]
- console.log @handledEvents
value
#
@@ -495,10 +493,11 @@ onKeydown = (event) ->
KeydownEvents.push event
onKeyup = (event) ->
+ handledKeydown = KeydownEvents.pop event
return unless handlerStack.bubbleEvent("keyup", event)
# Don't propagate the keyup to the underlying page if Vimium has handled it. See #733.
- DomUtils.suppressPropagation(event) if KeydownEvents.pop event
+ DomUtils.suppressPropagation(event) if handledKeydown
checkIfEnabledForUrl = ->
url = window.location.toString()