From 82f8ccd6a8376aa854f21bf13d3649f548422fdf Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Mon, 15 Dec 2014 08:46:00 +0000 Subject: Fix second memory leak in KeydownEvents. --- content_scripts/vimium_frontend.coffee | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index 0385f99b..16783bda 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -361,11 +361,9 @@ KeydownEvents = # Yields truthy or falsy depending upon whether a corresponding keydown event is present (and removes that # event). pop: (event) -> - console.log @handledEvents detailString = @stringify event value = @handledEvents[detailString] delete @handledEvents[detailString] - console.log @handledEvents value # @@ -495,10 +493,11 @@ onKeydown = (event) -> KeydownEvents.push event onKeyup = (event) -> + handledKeydown = KeydownEvents.pop event return unless handlerStack.bubbleEvent("keyup", event) # Don't propagate the keyup to the underlying page if Vimium has handled it. See #733. - DomUtils.suppressPropagation(event) if KeydownEvents.pop event + DomUtils.suppressPropagation(event) if handledKeydown checkIfEnabledForUrl = -> url = window.location.toString() -- cgit v1.2.3