diff options
| author | Ox Cart | 2017-09-12 05:43:24 -0500 | 
|---|---|---|
| committer | Ox Cart | 2017-09-12 05:44:13 -0500 | 
| commit | 30f8293685963e71f35e1beaf2672bf4729905be (patch) | |
| tree | dacc99d7ea359c9a3b60a9984d986f99f3477c35 | |
| parent | 85503b092f6516ad0fcf24018b6ff4d67a457146 (diff) | |
| download | systray-30f8293685963e71f35e1beaf2672bf4729905be.tar.bz2 | |
Code review fixes
| -rw-r--r-- | systray_darwin.m | 2 | ||||
| -rw-r--r-- | systray_linux.c | 6 | 
2 files changed, 5 insertions, 3 deletions
| diff --git a/systray_darwin.m b/systray_darwin.m index 485256d..3a28c73 100644 --- a/systray_darwin.m +++ b/systray_darwin.m @@ -127,7 +127,7 @@      return;    }    menuItem = [menu itemAtIndex: existedMenuIndex]; -  [menuItem setHidden:NO]; +  [menuItem setHidden:FALSE];  }  - (void) quit diff --git a/systray_linux.c b/systray_linux.c index 7258613..64d7e8f 100644 --- a/systray_linux.c +++ b/systray_linux.c @@ -117,9 +117,10 @@ gboolean do_hide_menu_item(gpointer data) {  		MenuItemNode* item = (MenuItemNode*)(it->data);  		if(item->menu_id == mii->menu_id){  			gtk_widget_hide(GTK_WIDGET(item->menu_item)); -			return; +			break;  		}  	} +	return FALSE;  }  // runs in main thread, should always return FALSE to prevent gtk to execute it again @@ -130,9 +131,10 @@ gboolean do_show_menu_item(gpointer data) {  		MenuItemNode* item = (MenuItemNode*)(it->data);  		if(item->menu_id == mii->menu_id){  			gtk_widget_show(GTK_WIDGET(item->menu_item)); -			return; +			break;  		}  	} +	return FALSE;  }  // runs in main thread, should always return FALSE to prevent gtk to execute it again | 
