Make Node configurable (#89)

2 files changed, 39 insertions, 1 deletions

diff --git a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/CssPluginTest.java b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/CssPluginTest.java
index c5d9bbd..7dfe16b 100644
--- a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/CssPluginTest.java
+++ b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/CssPluginTest.java
@@ -36,6 +36,15 @@ public class CssPluginTest {
     Plugin.Context context = new Plugin.Context(runtime);
     Plugin underTest = new CssPlugin();
     underTest.define(context);
-    assertThat(context.getExtensions()).hasSize(9);
+    assertThat(context.getExtensions()).hasSize(10);
+  }
+
+  @Test
+  public void count_extensions_7_2() {
+    SonarRuntime runtime = SonarRuntimeImpl.forSonarQube(Version.create(7, 2), SonarQubeSide.SCANNER);
+    Plugin.Context context = new Plugin.Context(runtime);
+    Plugin underTest = new CssPlugin();
+    underTest.define(context);
+    assertThat(context.getExtensions()).hasSize(11);
   }
 }
diff --git a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintCommandProviderTest.java b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintCommandProviderTest.java
index 7244cce..3ae3250 100644
--- a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintCommandProviderTest.java
+++ b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintCommandProviderTest.java
@@ -20,13 +20,24 @@
 package org.sonar.css.plugin;
 
 import java.io.File;
+import org.junit.Rule;
 import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
 import org.sonar.api.batch.sensor.internal.SensorContextTester;
+import org.sonar.api.config.internal.MapSettings;
+import org.sonar.api.utils.log.LogTester;
+import org.sonar.api.utils.log.LoggerLevel;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
 public class StylelintCommandProviderTest {
 
+  @Rule
+  public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+  @Rule
+  public final LogTester logTester = new LogTester();
+
   @Test
   public void test() throws Exception {
     StylelintCommandProvider stylelintCommandProvider = new StylelintCommandProvider();
@@ -44,4 +55,22 @@ public class StylelintCommandProviderTest {
       "json"
     );
   }
+
+  @Test
+  public void test_node_executable() throws Exception {
+    StylelintCommandProvider stylelintCommandProvider = new StylelintCommandProvider();
+
+    MapSettings settings = new MapSettings();
+    assertThat(stylelintCommandProvider.nodeExecutable(settings.asConfig())).isEqualTo("node");
+    assertThat(logTester.logs(LoggerLevel.WARN)).isEmpty();
+
+    File customNode = temporaryFolder.newFile("custom-node.exe");
+    settings.setProperty(CssPlugin.NODE_EXECUTABLE, customNode.getAbsolutePath());
+    assertThat(stylelintCommandProvider.nodeExecutable(settings.asConfig())).isEqualTo(customNode.getAbsolutePath());
+    assertThat(logTester.logs(LoggerLevel.WARN)).isEmpty();
+
+    settings.setProperty(CssPlugin.NODE_EXECUTABLE, "mynode");
+    assertThat(stylelintCommandProvider.nodeExecutable(settings.asConfig())).isEqualTo("node");
+    assertThat(logTester.logs(LoggerLevel.WARN)).contains("Provided node executable file does not exist: mynode");
+  }
 }