diff options
| author | Elena Vilchik | 2019-06-13 18:09:27 +0200 |
|---|---|---|
| committer | Tibor Blenessy | 2019-06-13 18:09:27 +0200 |
| commit | 479b21eb67bd2f5f7170cb4e14b19561ed59ddcf (patch) | |
| tree | 1e5d4c8de4d87d6add3f324f51bd21e153aeaa1e /its/plugin | |
| parent | 6581b69a11c27d11ba5e1f4c37546485dc12b1d4 (diff) | |
| download | sonar-css-479b21eb67bd2f5f7170cb4e14b19561ed59ddcf.tar.bz2 | |
Add rule S5362: Expressions within "calc" should be valid (#180)
Removes S4650 from the default profile, because of overlap.
Diffstat (limited to 'its/plugin')
4 files changed, 4 insertions, 0 deletions
diff --git a/its/plugin/projects/issues-project/src/file1.css b/its/plugin/projects/issues-project/src/file1.css index d53007e..a6de7ce 100644 --- a/its/plugin/projects/issues-project/src/file1.css +++ b/its/plugin/projects/issues-project/src/file1.css @@ -27,6 +27,7 @@ a:unknown { /* S4659 | selecto padding-left: 10px; padding: 20px; /* S4657 | declaration-block-no-shorthand-property-overrides */ top: calc(1px+2px); /* S4650 | function-calc-no-unspaced-operator */ /* S4653 | unit-no-unknown */ + width: calc(100% 80px); /* S5362 | function-calc-no-invalid */ } //color: pink; /* S4668 | no-invalid-double-slash-comments */ /* S4654 | property-no-unknown */ diff --git a/its/plugin/projects/issues-project/src/file2.less b/its/plugin/projects/issues-project/src/file2.less index 1519d88..a838bcd 100644 --- a/its/plugin/projects/issues-project/src/file2.less +++ b/its/plugin/projects/issues-project/src/file2.less @@ -27,6 +27,7 @@ a:unknown { /* S4659 | selecto padding-left: 10px; padding: 20px; /* S4657 | declaration-block-no-shorthand-property-overrides */ top: calc(1px+2px); /* S4650 | function-calc-no-unspaced-operator */ /* S4653 | unit-no-unknown */ + width: calc(100% 80px); /* S5362 | function-calc-no-invalid */ } // color: pink; /* S4668 | no-invalid-double-slash-comments | Doesn't raise for LESS */ diff --git a/its/plugin/projects/issues-project/src/file3.scss b/its/plugin/projects/issues-project/src/file3.scss index 6f19ae1..1d10479 100644 --- a/its/plugin/projects/issues-project/src/file3.scss +++ b/its/plugin/projects/issues-project/src/file3.scss @@ -27,6 +27,7 @@ a:unknown { /* S4659 | selecto padding-left: 10px; padding: 20px; /* S4657 | declaration-block-no-shorthand-property-overrides */ top: calc(1px+2px); /* S4650 | function-calc-no-unspaced-operator */ /* S4653 | unit-no-unknown */ + width: calc(100% 80px); /* S5362 | function-calc-no-invalid */ } // color: pink; /* S4668 | no-invalid-double-slash-comments | Doesn't raise for SCSS */ diff --git a/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java b/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java index 9294357..ce57e15 100644 --- a/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java +++ b/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java @@ -63,6 +63,7 @@ public class IssuesTest { CssRules.getRuleClasses().size() * 3 /* issues are raised against .css, .less and .scss */ + 1 /* issue S4654 is raised for comment */ + 1 /* issue S4662 is raised for cssModules.css */ + + 6 /* S5362 raises at the same place as S4650 */ - 2 /* issue S4668 not raised on .less nor .scss */); } |