Rely on NodeJS API of Stylelint to execute CSS rules (#221)

4 files changed, 20 insertions, 5 deletions

diff --git a/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java b/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java
index 4419103..0a162a7 100644
--- a/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java
+++ b/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java
@@ -20,6 +20,7 @@
 package org.sonar.css.its;
 
 import com.sonar.orchestrator.Orchestrator;
+import com.sonar.orchestrator.build.BuildResult;
 import com.sonar.orchestrator.build.SonarScanner;
 import com.sonar.orchestrator.locator.FileLocation;
 import java.io.File;
@@ -45,6 +46,8 @@ public class IssuesTest {
   @ClassRule
   public static Orchestrator orchestrator = Tests.ORCHESTRATOR;
 
+  private static BuildResult buildResult;
+
   @BeforeClass
   public static void prepare() {
     RulesConfiguration rulesConfiguration = new RulesConfiguration();
@@ -56,12 +59,20 @@ public class IssuesTest {
     orchestrator.getServer().associateProjectToQualityProfile(PROJECT_KEY, "css", "rules");
 
     SonarScanner scanner = Tests.createScanner(PROJECT_KEY);
+    scanner.setProperty("sonar.exclusions", "**/file-with-parsing-error-excluded.css");
     scanner.setProperty("sonar.html.file.suffixes", ".htm");
-    orchestrator.executeBuild(scanner);
+    buildResult = orchestrator.executeBuild(scanner);
+  }
+
+  @Test
+  public void parsing_error_not_on_excluded_files() {
+    assertThat(buildResult.getLogs())
+      .doesNotMatch("(?s).*ERROR: Failed to parse file:\\S*file-with-parsing-error-excluded\\.css.*")
+      .matches("(?s).*ERROR: Failed to parse file:\\S*file-with-parsing-error\\.css, line 1, Unclosed block.*");
   }
 
   @Test
-  public void test() {
+  public void issue_list() {
     SearchRequest request = new SearchRequest();
     request.setComponentKeys(Collections.singletonList(PROJECT_KEY));
     List<Issue> issuesList = newWsClient().issues().search(request).getIssuesList().stream()
diff --git a/its/plugin/src/test/java/org/sonar/css/its/MetricsTest.java b/its/plugin/src/test/java/org/sonar/css/its/MetricsTest.java
index 275da9d..846adb1 100644
--- a/its/plugin/src/test/java/org/sonar/css/its/MetricsTest.java
+++ b/its/plugin/src/test/java/org/sonar/css/its/MetricsTest.java
@@ -42,8 +42,9 @@ public class MetricsTest {
 
   @Test
   public void test() {
-    assertThat(getProjectMeasureAsDouble("lines", PROJECT_KEY)).isEqualTo(32);
-    assertThat(getProjectMeasureAsDouble("ncloc", PROJECT_KEY)).isEqualTo(22);
+    assertThat(getProjectMeasureAsDouble("lines", PROJECT_KEY)).isEqualTo(43);
+    assertThat(getProjectMeasureAsDouble("ncloc", PROJECT_KEY)).isEqualTo(32);
+    assertThat(getMeasure("ncloc_language_distribution", PROJECT_KEY).getValue()).isEqualTo("css=22;web=10");
     assertThat(getProjectMeasureAsDouble("comment_lines", PROJECT_KEY)).isEqualTo(4);
 
     assertThat(getMeasure("ncloc_data", PROJECT_KEY + ":src/file1.css").getValue())
diff --git a/its/plugin/src/test/java/org/sonar/css/its/NoCssFileProjectTest.java b/its/plugin/src/test/java/org/sonar/css/its/NoCssFileProjectTest.java
index 04f2384..3feac8f 100644
--- a/its/plugin/src/test/java/org/sonar/css/its/NoCssFileProjectTest.java
+++ b/its/plugin/src/test/java/org/sonar/css/its/NoCssFileProjectTest.java
@@ -45,7 +45,6 @@ public class NoCssFileProjectTest {
   public static void prepare() {
     orchestrator.getServer().provisionProject(PROJECT_KEY, PROJECT_KEY);
     SonarScanner scanner = Tests.createScanner(PROJECT_KEY);
-    scanner.setProperty("sonar.php.file.suffixes", ".php");
     orchestrator.executeBuild(scanner);
   }
 
@@ -59,6 +58,7 @@ public class NoCssFileProjectTest {
 
     assertThat(issuesList).extracting(Issues.Issue::getRule, Issues.Issue::getLine, Issues.Issue::getComponent).containsExactlyInAnyOrder(
       tuple("css:S4658", 7, "php-project:src/index.php"));
+
   }
 
 }
diff --git a/its/plugin/src/test/java/org/sonar/css/its/Tests.java b/its/plugin/src/test/java/org/sonar/css/its/Tests.java
index bc9a418..d6f109e 100644
--- a/its/plugin/src/test/java/org/sonar/css/its/Tests.java
+++ b/its/plugin/src/test/java/org/sonar/css/its/Tests.java
@@ -23,6 +23,7 @@ import com.sonar.orchestrator.Orchestrator;
 import com.sonar.orchestrator.OrchestratorBuilder;
 import com.sonar.orchestrator.build.SonarScanner;
 import com.sonar.orchestrator.locator.FileLocation;
+import com.sonar.orchestrator.locator.MavenLocation;
 import java.io.File;
 import java.util.Collections;
 import java.util.List;
@@ -55,6 +56,8 @@ public class Tests {
 
   static {
     OrchestratorBuilder orchestratorBuilder = Orchestrator.builderEnv()
+      .addPlugin(MavenLocation.of("org.sonarsource.php", "sonar-php-plugin", "LATEST_RELEASE"))
+      .addPlugin(MavenLocation.of("org.sonarsource.html", "sonar-html-plugin", "LATEST_RELEASE"))
       .addPlugin(PLUGIN_LOCATION)
       .setSonarVersion(System.getProperty("sonar.runtimeVersion", "LATEST_RELEASE"));
     ORCHESTRATOR = orchestratorBuilder.build();