| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2014-12-28 | Use formula helper in tests | Jack Nagel | |
| 2014-12-26 | Unroll validation loop | Jack Nagel | |
| 2014-12-26 | Overriding #initialize is not supported, so drop late validation | Jack Nagel | |
| 2014-10-30 | Use more relevant assertions | Jack Nagel | |
| 2014-06-18 | Use a custom test class so we can avoid monkeypatching | Jack Nagel | |
| 2014-04-06 | Clean up test classes | Jack Nagel | |
| 2013-10-14 | Assert on state, not something that didn't happen | Jack Nagel | |
| 2013-07-22 | Silence warnings | Jack Nagel | |
| 2013-06-07 | Fix failing test | Jack Nagel | |
| 2013-05-25 | tests: extract common formula helper | Jack Nagel | |
| 2013-04-27 | Don't test error message | Jack Nagel | |
| Now that we are testing for a custom exception type, we don't need to make any assertion about the message. | |||
| 2013-04-27 | Allow `brew versions` to work with underspecified formulae | Jack Nagel | |
| 2013-04-13 | Make a specific assertion in this test | Jack Nagel | |
| 2013-04-13 | Raise a useful exception for incomplete formulae | Jack Nagel | |
| 2013-04-13 | Allow "devel-only" formulae | Jack Nagel | |
| It seems only natural that this should be possible, or at the very least, it should not result in calling methods on nil. | |||
| 2013-04-13 | Improved formula attribute validation | Jack Nagel | |
| The initializer for Formula does a number of validations, but it does them in a weird order, and some attributes aren't validated under certain circumstances. This became even more of a mess when most software package attributes were moved into the SoftwareSpec class. This commit removes the last vestiges of storing these attributes as instance variables. In particular, it eliminates #set_instance_variable and #validate_variable, replacing them with methods that operate on SoftwareSpec instances, and generate more useful errors. Doing these validations unconditionally in the initializer means we bail out much earlier if the formula has invalid attributes or is not fully specified, and no longer need to validate in #prefix. Technically we don't need to validate in #brew either, but we continue to do so anyway as a safety measure, and because we cannot enforce calls to super in subclasses. | |||
