aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/cmd/audit.rb
AgeCommit message (Collapse)Author
2015-04-19Revert "audit: enforce new https url style for gnome downloads"Jack Nagel
I would like there to be more discussion before making this change. This reverts commit f16ffd2a9ee5d29c7c0ae672c17bd129240adbb5.
2015-04-19audit: enforce new https url style for gnome downloadsViktor Szakats
also delete extra closing parenthesis in two problem messages Closes #38824. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-04-19audit: version string should not be ambiguous with revision partXu Cheng
Closes #38810. Signed-off-by: Xu Cheng <xucheng@me.com>
2015-04-12audit: don't split shell commands when using a glob patternBaptiste Fontaine
Without this, `brew audit <some formula>` may ask people to change: system "./script.sh foo-*" into: system "./script.sh", "foo-*" These are not the same. In the first example the shell expansion occurs while it doesn’t in the second one, breaking the build. Closes #38540. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-04-02audit: enforce https for bare bintray.com domainViktor Szakáts
Closes #38302. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-03-31audit: enforce https on *.bintray.com urlsViktor Szakáts
Closes #38209. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-03-18audit: fix to enforce https for apache homepageViktor Szakáts
It was failing to recognize the URL without an ending slash. Closes #37808. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-03-17audit: enforce https for apache.orgViktor Szakáts
- including all apache.org subdomains - for `homepage` as well Closes #37778. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-03-15audit: suggest to not using git as dependencyXu Cheng
Closes #37696 Closes #37703 Closes #37735. Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-12audit: Clarify GNU url warning messagechdiza
"ftpmirror.gnu.org" must have a protocol prefix of "http", not "https". Closes #37567. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-03-10audit: whitelist pipe, redirect etc in the system checkXu Cheng
Closes #37523. Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-08audit: git tags should also specify revisions.Mike McQuaid
2015-03-05checksums: switch to sha256 for bottles and new formulaeDominyk Tiller
Closes #37164. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-03-04audit: deprecate ScriptFileFormulaXu Cheng
Closes #37356. Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-03audit: deprecate AmazonWebServicesFormulaXu Cheng
Closes #37355. Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-02brew audit: req https for archive.apache.org urlsViktor Szakáts
Closes #37313. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-27audit: handle head/devel-only correctly.Mike McQuaid
2015-02-25audit: suggest setting JAVA_HOME by `depends_on :java`Xu Cheng
Closes #37174. Signed-off-by: Xu Cheng <xucheng@me.com>
2015-02-24fix auditXu Cheng
2015-02-24audit: fix FormulaText matchXu Cheng
It's used in `audit_text` Closes #37139. Signed-off-by: Xu Cheng <xucheng@me.com>
2015-02-19audit: give better suggestion on git/hg dependencyXu Cheng
Closes #36959. Signed-off-by: Xu Cheng <xucheng@me.com>
2015-02-19audit: check for setuid in caveats.Mike McQuaid
2015-02-17audit: extend ssl checksDominyk Tiller
Extends the audit checks to GnuPG, a significant chunk of Freedesktop domains, and Github Pages. I’ve somewhat hardened my stance towards Github Pages from the last time we extended this, hence the new inclusion - I did a pretty thorough check through the Homebrew formulae that use Github Pages for homepage links and found very few places where enforcing SSL/TLS would cause issues - I think a wider enforcement is worthwhile. I’ve also fixed the capitalisation of the taps, if only because at the moment it disagrees with what ` puts formula.tap ` outputs (We get Homebrew/homebrew-head-only rather than homebrew/homebrew-head-only for example). Closes #36719. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-17audit: more information on build deps auditXu Cheng
Closes #36892. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-14audit: catch empty installationsXu Cheng
Closes #36794. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08audit: catch more examples from example_formulaDominyk Tiller
See https://github.com/Homebrew/homebrew/pull/36629#discussion_r24293912 amongst other recent examples. The example formula isn’t as strongly policed as the ` brew create ` default, this tries to do something about that. Closes #36639. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-26audit: stop red-flagging devel-onlyDominyk Tiller
Currently the bot is failing certain devel-only formulae because it thinks having ` devel ` defined with an added ` head ` defined as well = a head-only formula. ``` ==> audit problems docker-machine: * Head-only (no stable download) ``` This is a pretty simple fix for that problem: ``` ==> brew style docker-machine 1 file inspected, no offenses detected ``` Closes #36197. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-22Deprecate GithubGistFormulaJack Nagel
Closes #36094.
2015-01-22Audit check for gnome unstable as stableJack Nagel
2015-01-06audit: improve ssl/tls detectionDominyk Tiller
I don’t know how maintainers are going to feel about this, to be honest. If it’s too clunky, perhaps we could externalise the entire two main blocks here and then require that file into the audit instead? Basically, I’m pushing changes here to better detect a wide-array of SSL/TLS available links that either have no auto-redirect in place or is a common linking error in formulae. I haven’t spotted any false positives yet, but obviously, feel free to try and break the changes and I’ll fix as necessary ;). IMO, this would allow us gradual updates without having to mass-update everything at once and stress the bot and inform users they have hundreds of updates pending when really it’s just style/basic changes. Closes #35551. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-05audit (strict): only run `brew style` with Ruby 2.Mike McQuaid
2015-01-04audit: also run `brew style` on `--strict`.Mike McQuaid
Closes #35465. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-02audit: system check fixed for multiple argumentsBaptiste Fontaine
Closes #35459. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-12-27Revert "audit (strict): check for use double-quotes."Jack Nagel
This reverts commit 8fe14451842dea92bca04116ba043421b4f44a6b. Conflicts: Library/Homebrew/cmd/audit.rb
2014-12-27Rename HEAD only tap.Mike McQuaid
2014-12-27audit: simplify test defined check.Mike McQuaid
2014-12-27audit: improve FileUtils check.Mike McQuaid
Match the parens properly and only interpolate once. Closes #35288. Closes #35291.
2014-12-27audit (strict): add require formula check.Mike McQuaid
2014-12-27audit (strict): check a test is present.Mike McQuaid
2014-12-27audit (strict): whitelist 32-bit in options check.Mike McQuaid
2014-12-27audit (strict): check for use double-quotes.Mike McQuaid
2014-12-27audit (strict): check for use of spaces in system.Mike McQuaid
2014-12-27audit: check for use of FileUtils methods.Mike McQuaid
2014-12-27audit: check options when in strict mode.Mike McQuaid
2014-12-27audit: add strict mode, argument.Mike McQuaid
2014-12-22Fix formula template comment auditJack Nagel
2014-12-22Deprecate appending the CVS module name to the URL stringJack Nagel
2014-12-19Deprecate made-up URL schemesJack Nagel
This deprecates URLs that begin with the following fake URL schemes: bzr:// cvs:// hg:// fossil:// svn+http:// Despite their appearance, they are not actually accepted by the corresponding tools. They exist only as hints to the download strategy detection code, and are stripped from the URL before the URL is handed off to the VCS program. This is not documented, and may lead one to believe it is a valid URL that can be used elsewhere, when it actually only works inside Homebrew. We have a better mechanism for specifying the download strategy that is straightforward and explicit: :using => :hg Recommend that instead. Closes #35114.
2014-12-18Deprecate UnsafeSubversionDownloadStrategyJack Nagel
2014-11-12One less place where Formula is reopenedJack Nagel
generated by cgit v1.2.3 (git 2.25.1) at 2026-02-05 13:37:37 +0000