diff options
| author | Jack Nagel | 2014-07-03 19:29:18 -0500 |
|---|---|---|
| committer | Jack Nagel | 2014-07-03 19:29:18 -0500 |
| commit | cc64755b05c15fc0c6b4c024d40e40199877b420 (patch) | |
| tree | 37f5694ddd9bf285eb746e7f167d611bc9e92355 /Library | |
| parent | cb5b24dff889f75aa606c4dc9bee6f8b77302b60 (diff) | |
| download | homebrew-cc64755b05c15fc0c6b4c024d40e40199877b420.tar.bz2 | |
Option does not need to be Comparable
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/options.rb | 5 | ||||
| -rw-r--r-- | Library/Homebrew/test/test_options.rb | 1 |
2 files changed, 2 insertions, 4 deletions
diff --git a/Library/Homebrew/options.rb b/Library/Homebrew/options.rb index 107f663c0..d273239bb 100644 --- a/Library/Homebrew/options.rb +++ b/Library/Homebrew/options.rb @@ -1,8 +1,6 @@ require 'set' class Option - include Comparable - attr_reader :name, :description, :flag def initialize(name, description=nil) @@ -20,9 +18,10 @@ class Option name <=> other.name end - def eql?(other) + def ==(other) instance_of?(other.class) && name == other.name end + alias_method :eql?, :== def hash name.hash diff --git a/Library/Homebrew/test/test_options.rb b/Library/Homebrew/test/test_options.rb index a31bf91be..4b9915874 100644 --- a/Library/Homebrew/test/test_options.rb +++ b/Library/Homebrew/test/test_options.rb @@ -21,7 +21,6 @@ class OptionTests < Homebrew::TestCase refute_equal bar, @option assert_eql @option, foo refute_eql @option, bar - assert_operator bar, :<, foo end def test_strips_leading_dashes |
