docbook: use resources

1 files changed, 47 insertions, 67 deletions

diff --git a/Library/Formula/docbook.rb b/Library/Formula/docbook.rb
index 51c79f9c3..821b98ebe 100644
--- a/Library/Formula/docbook.rb
+++ b/Library/Formula/docbook.rb
@@ -5,23 +5,57 @@ class Docbook < Formula
   url 'http://www.docbook.org/xml/5.0/docbook-5.0.zip'
   sha1 '49f274e67efdee771300cba4da1f3e4bc00be1ec'
 
-  def install
-    # Install 4.1.2 *after* 4.2, because we need to borrow the catalog.xml
-    # file from the 4.2 package.
-    packages = [Docbookxml42,
-                Docbookxml412,
-                Docbookxml43,
-                Docbookxml44,
-                Docbookxml45,
-                Docbookxml50]
+  resource 'xml412' do
+    url 'http://www.docbook.org/xml/4.1.2/docbkx412.zip'
+    sha1 'b9ae7a41056bfaf885581812d60651b7b5531519'
+    version '4.1.2'
+  end
+
+  resource 'xml42' do
+    url 'http://www.docbook.org/xml/4.2/docbook-xml-4.2.zip'
+    sha1 '5e3a35663cd028c5c5fbb959c3858fec2d7f8b9e'
+  end
+
+  resource 'xml43' do
+    url 'http://www.docbook.org/xml/4.3/docbook-xml-4.3.zip'
+    sha1 'e79a59e9164c1013b8cc9f64f96f909a184ca016'
+  end
+
+  resource 'xml44' do
+    url 'http://www.docbook.org/xml/4.4/docbook-xml-4.4.zip'
+    sha1 '7c4d91c82ad3747e1b5600c91782758e5d91c22b'
+  end
+
+  resource 'xml45' do
+    url 'http://www.docbook.org/xml/4.5/docbook-xml-4.5.zip'
+    sha1 'b9124233b50668fb508773aa2b3ebc631d7c1620'
+  end
+
+  resource 'xml50' do
+    url 'http://www.docbook.org/xml/5.0/docbook-5.0.zip'
+    sha1 '49f274e67efdee771300cba4da1f3e4bc00be1ec'
+  end
 
+  def install
     (etc/'xml').mkpath
     system "xmlcatalog", "--noout", "--create", "#{etc}/xml/catalog"
 
-    packages.each do |pkg|
-      pkg.new.brew do |f|
-        f.install
-        catalog = prefix/f.catalog/'catalog.xml'
+    %w{42 412 43 44 45 50}.each do |version|
+      resource("xml#{version}").stage do |r|
+        if version == "412"
+          cp prefix/'docbook/xml/4.2/catalog.xml', 'catalog.xml'
+
+          inreplace 'catalog.xml' do |s|
+            s.gsub! 'V4.2 ..', 'V4.1.2 '
+            s.gsub! '4.2', '4.1.2'
+          end
+        end
+
+        rm_rf 'docs'
+        (prefix/'docbook/xml'/r.version).install Dir['*']
+
+        catalog = prefix/"docbook/xml/#{r.version}/catalog.xml"
+
         system "xmlcatalog", "--noout", "--del",
                              "file://#{catalog}", "#{etc}/xml/catalog"
         system "xmlcatalog", "--noout", "--add", "nextCatalog",
@@ -38,57 +72,3 @@ class Docbook < Formula
     EOS
   end
 end
-
-class Docbookxml < Formula
-  def install
-    rm_rf 'docs'
-    docbook = Formula.factory 'docbook'
-    (docbook.prefix/'docbook/xml'/version).install Dir['*']
-  end
-
-  def catalog
-    "docbook/xml/#{version}"
-  end
-end
-
-class Docbookxml412 < Docbookxml
-  url 'http://www.docbook.org/xml/4.1.2/docbkx412.zip'
-  sha1 'b9ae7a41056bfaf885581812d60651b7b5531519'
-  version '4.1.2'
-
-  def install
-    cp Formula.factory('docbook').prefix/'docbook/xml/4.2/catalog.xml', 'catalog.xml'
-
-    inreplace 'catalog.xml' do |s|
-      s.gsub! 'V4.2 ..', 'V4.1.2 '
-      s.gsub! '4.2', '4.1.2'
-    end
-
-    super
-  end
-end
-
-class Docbookxml42 < Docbookxml
-  url 'http://www.docbook.org/xml/4.2/docbook-xml-4.2.zip'
-  sha1 '5e3a35663cd028c5c5fbb959c3858fec2d7f8b9e'
-end
-
-class Docbookxml43 < Docbookxml
-  url 'http://www.docbook.org/xml/4.3/docbook-xml-4.3.zip'
-  sha1 'e79a59e9164c1013b8cc9f64f96f909a184ca016'
-end
-
-class Docbookxml44 < Docbookxml
-  url 'http://www.docbook.org/xml/4.4/docbook-xml-4.4.zip'
-  sha1 '7c4d91c82ad3747e1b5600c91782758e5d91c22b'
-end
-
-class Docbookxml45 < Docbookxml
-  url 'http://www.docbook.org/xml/4.5/docbook-xml-4.5.zip'
-  sha1 'b9124233b50668fb508773aa2b3ebc631d7c1620'
-end
-
-class Docbookxml50 < Docbookxml
-  url 'http://www.docbook.org/xml/5.0/docbook-5.0.zip'
-  sha1 '49f274e67efdee771300cba4da1f3e4bc00be1ec'
-end