diff options
| author | Jack Nagel | 2012-08-22 19:49:17 -0500 |
|---|---|---|
| committer | Jack Nagel | 2012-10-24 22:59:24 -0500 |
| commit | b4f65f5171dfb43e2ab36f9d470ad17258a81ea3 (patch) | |
| tree | 4d7fa479c9482adf25c94592fc52ddc068691472 /Library | |
| parent | f18076a0dd89a55a6dd9372b0e1fb5e1069427bd (diff) | |
| download | homebrew-b4f65f5171dfb43e2ab36f9d470ad17258a81ea3.tar.bz2 | |
FormulaInstaller: disambiguate show_header usage
show_header should default to false (we don't want to display it in the
case of installing a single formula without dependencies), but it only
worked this way by accident.
The assignment "show_header = true" creates a local variable named
show_header, and in the case where needed_deps is empty and this
assignment is not actually executed, the latter usage evaluates the
local variable instead of calling the method.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/formula_installer.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index 5ceaa9fe4..65f6d44b3 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -15,7 +15,7 @@ class FormulaInstaller def initialize ff, tab=nil @f = ff @tab = tab - @show_header = true + @show_header = false @ignore_deps = ARGV.ignore_deps? || ARGV.interactive? @install_bottle = install_bottle? ff @@ -99,7 +99,7 @@ class FormulaInstaller end end # now show header as all the deps stuff has clouded the original issue - show_header = true + @show_header = true end end |