linkapps: overwrite broken app symlinks

Closes #22388.
Closes #22430.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

1 files changed, 2 insertions, 4 deletions

diff --git a/Library/Contributions/cmd/brew-linkapps.rb b/Library/Contributions/cmd/brew-linkapps.rb
index ce3f4960a..41f1459a2 100755
--- a/Library/Contributions/cmd/brew-linkapps.rb
+++ b/Library/Contributions/cmd/brew-linkapps.rb
@@ -20,13 +20,11 @@ HOMEBREW_CELLAR.subdirs.each do |rack|
     app_name = File.basename(app)
     target = "#{TARGET_DIR}/#{app_name}"
 
-    if File.exist?(target) && File.symlink?(target)
-      system "rm", target
-    elsif File.exist?(target)
+    if File.exist?(target) && !File.symlink?(target)
       onoe "#{target} already exists, skipping."
       next
     end
-    system "ln", "-s", app, TARGET_DIR
+    system "ln", "-sf", app, TARGET_DIR
   end
 end