diff options
| author | Steven Peters | 2015-01-12 23:21:18 -0800 |
|---|---|---|
| committer | Jack Nagel | 2015-01-17 22:58:56 -0600 |
| commit | 991b6b702edd332587e644a91cdbc7865d25cdf6 (patch) | |
| tree | 5077c7180ef918238ad84af3538341317f0b8ae9 /Library | |
| parent | 9ef258aa6dc6106cb3016d1d096dc5509e337f60 (diff) | |
| download | homebrew-991b6b702edd332587e644a91cdbc7865d25cdf6.tar.bz2 | |
Fix brew test linking errors in several formula on 10.10
OS X 10.10 seems to require "-L{lib}" as a C/C++ compiler
argument in order to link properly. This is causing
several brew test failures.
This patch modifies several formula in a single commit
by adding "-L{lib}" to the brew test ENV.cc argument
lists. I manually verified that these specific tests
are failing with the change and passing with it on 10.10.
To identify other formulae that may be subject to this
issue, the following may be used:
~~~
grep -rnI 'ENV\.cc.*test\.c' Library/Formula \
| grep -v '\-L#{lib}'
~~~
Closes #35806.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Formula/assimp.rb | 2 | ||||
| -rw-r--r-- | Library/Formula/gmp.rb | 2 | ||||
| -rw-r--r-- | Library/Formula/libtiff.rb | 2 | ||||
| -rw-r--r-- | Library/Formula/tinyxml.rb | 2 | ||||
| -rw-r--r-- | Library/Formula/tinyxml2.rb | 2 | ||||
| -rw-r--r-- | Library/Formula/zeromq.rb | 2 |
6 files changed, 6 insertions, 6 deletions
diff --git a/Library/Formula/assimp.rb b/Library/Formula/assimp.rb index 6fcea789c..3580de27a 100644 --- a/Library/Formula/assimp.rb +++ b/Library/Formula/assimp.rb @@ -35,7 +35,7 @@ class Assimp < Formula return 0; } EOS - system ENV.cc, "test.cpp", "-lassimp", "-o", "test" + system ENV.cc, "test.cpp", "-L#{lib}", "-lassimp", "-o", "test" system "./test" # Application test. diff --git a/Library/Formula/gmp.rb b/Library/Formula/gmp.rb index 3606d4b2f..3534a6964 100644 --- a/Library/Formula/gmp.rb +++ b/Library/Formula/gmp.rb @@ -48,7 +48,7 @@ class Gmp < Formula return 0; } EOS - system ENV.cc, "test.c", "-lgmp", "-o", "test" + system ENV.cc, "test.c", "-L#{lib}", "-lgmp", "-o", "test" system "./test" end end diff --git a/Library/Formula/libtiff.rb b/Library/Formula/libtiff.rb index bbd9fc506..611bdb755 100644 --- a/Library/Formula/libtiff.rb +++ b/Library/Formula/libtiff.rb @@ -42,7 +42,7 @@ class Libtiff < Formula return 0; } EOS - system ENV.cc, "test.c", "-ltiff", "-o", "test" + system ENV.cc, "test.c", "-L#{lib}", "-ltiff", "-o", "test" system "./test", "test.tif" assert_match /ImageWidth.*10/, shell_output("#{bin}/tiffdump test.tif") end diff --git a/Library/Formula/tinyxml.rb b/Library/Formula/tinyxml.rb index 361347693..813f6d8a0 100644 --- a/Library/Formula/tinyxml.rb +++ b/Library/Formula/tinyxml.rb @@ -71,7 +71,7 @@ class Tinyxml < Formula return 0; } EOS - system ENV.cxx, "test.cpp", "-ltinyxml", "-o", "test" + system ENV.cxx, "test.cpp", "-L#{lib}", "-ltinyxml", "-o", "test" system "./test" end end diff --git a/Library/Formula/tinyxml2.rb b/Library/Formula/tinyxml2.rb index 0d789945b..f4b04311b 100644 --- a/Library/Formula/tinyxml2.rb +++ b/Library/Formula/tinyxml2.rb @@ -28,7 +28,7 @@ class Tinyxml2 < Formula return 0; } EOS - system ENV.cc, "test.cpp", "-ltinyxml2", "-o", "test" + system ENV.cc, "test.cpp", "-L#{lib}", "-ltinyxml2", "-o", "test" system "./test" end end diff --git a/Library/Formula/zeromq.rb b/Library/Formula/zeromq.rb index 10a9ccf7c..f557a68ad 100644 --- a/Library/Formula/zeromq.rb +++ b/Library/Formula/zeromq.rb @@ -59,7 +59,7 @@ class Zeromq < Formula return 0; } EOS - system ENV.cc, "test.c", "-lzmq", "-o", "test" + system ENV.cc, "test.c", "-L#{lib}", "-lzmq", "-o", "test" system "./test" end end |
