Eliminate boolean argument to Version.new

1 files changed, 11 insertions, 7 deletions

diff --git a/Library/Homebrew/version.rb b/Library/Homebrew/version.rb
index a35c22974..ca5311c8f 100644
--- a/Library/Homebrew/version.rb
+++ b/Library/Homebrew/version.rb
@@ -155,26 +155,30 @@ class Version
     StringToken::PATTERN
   )
 
+  class FromURL < Version
+    def detected_from_url?
+      true
+    end
+  end
+
   def self.detect(url, specs={})
     if specs.has_key?(:tag)
-      new(specs[:tag][/((?:\d+\.)*\d+)/, 1], true)
+      FromURL.new(specs[:tag][/((?:\d+\.)*\d+)/, 1])
     else
-      parse(url)
+      FromURL.parse(url)
     end
   end
 
-  def initialize(val, detected=false)
+  def initialize(val)
     if val.respond_to?(:to_str)
       @version = val.to_str
     else
       raise TypeError, "Version value must be a string"
     end
-
-    @detected_from_url = detected
   end
 
   def detected_from_url?
-    @detected_from_url
+    false
   end
 
   def head?
@@ -236,7 +240,7 @@ class Version
 
   def self.parse spec
     version = _parse(spec)
-    new(version, true) unless version.nil?
+    new(version) unless version.nil?
   end
 
   def self._parse spec