aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorXu Cheng2015-02-17 18:02:05 +0800
committerMike McQuaid2015-02-17 10:30:42 +0000
commit526e145b20c1ea96f557cd1336871c242716ef32 (patch)
tree5fa17e2e466d0753021160b4b46eb71bf848b14c /Library
parent7fb42a2d00eaffadf99ec13d2618ecd85bf59095 (diff)
downloadhomebrew-526e145b20c1ea96f557cd1336871c242716ef32.tar.bz2
test-bot: fail fast in check_results
Closes #36893. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cmd/test-bot.rb8
1 files changed, 3 insertions, 5 deletions
diff --git a/Library/Homebrew/cmd/test-bot.rb b/Library/Homebrew/cmd/test-bot.rb
index 9a1478764..2617aee87 100644
--- a/Library/Homebrew/cmd/test-bot.rb
+++ b/Library/Homebrew/cmd/test-bot.rb
@@ -549,15 +549,13 @@ module Homebrew
end
def check_results
- status = :passed
- steps.each do |step|
+ steps.all? do |step|
case step.status
- when :passed then next
+ when :passed then true
when :running then raise
- when :failed then status = :failed
+ when :failed then false
end
end
- status == :passed
end
def formulae