diff options
| author | Adam Vandenberg | 2012-09-03 19:18:58 -0700 |
|---|---|---|
| committer | Adam Vandenberg | 2012-09-03 19:49:33 -0700 |
| commit | 3e6403c16b5d2969e64bd00b74820115a1ca2e50 (patch) | |
| tree | 367f8b59031dd7c92a6f2e0a63fc546432aa7574 /Library | |
| parent | c985c6c0575b38a4a8e6089ca4a3704b9e11f258 (diff) | |
| download | homebrew-3e6403c16b5d2969e64bd00b74820115a1ca2e50.tar.bz2 | |
add audit for ENV.x11
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/cmd/audit.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index b0efe040f..030555beb 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -352,6 +352,10 @@ class FormulaAuditor problem "xcodebuild should be passed an explicit \"SYMROOT\"" end + if text =~ /ENV\.x11/ + problem "Use \"depends_on :x11\" instead of \"ENV.x11\"" + end + # Avoid hard-coding compilers if text =~ %r[(system|ENV\[.+\]\s?=)\s?['"](/usr/bin/)?(gcc|llvm-gcc|clang)['" ]] problem "Use \"\#{ENV.cc}\" instead of hard-coding \"#{$3}\"" |