diff options
| author | Adam Vandenberg | 2009-11-18 15:43:00 -0800 |
|---|---|---|
| committer | Adam Vandenberg | 2009-11-18 15:43:00 -0800 |
| commit | 32da375fc69e4aae495482037ae8ec8ba51d514d (patch) | |
| tree | f02d76e5f9eb1730c58d03af4b1e45ff0b1d7305 /Library | |
| parent | 65fa65ede6546ae9bb620ac9f8f8220bee12186f (diff) | |
| download | homebrew-32da375fc69e4aae495482037ae8ec8ba51d514d.tar.bz2 | |
Add test for legacy prefix quoting.
Diffstat (limited to 'Library')
| -rwxr-xr-x | Library/Homebrew/test/formula_test.rb | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/Library/Homebrew/test/formula_test.rb b/Library/Homebrew/test/formula_test.rb index c79c62571..c9033390a 100755 --- a/Library/Homebrew/test/formula_test.rb +++ b/Library/Homebrew/test/formula_test.rb @@ -39,11 +39,22 @@ class FormulaNames <Test::Unit::TestCase end end -class CommentedTemplateCode <Test::Unit::TestCase +class WellKnownCodeIssues <Test::Unit::TestCase def test_for_commented_out_cmake Dir["#{HOMEBREW_PREFIX}/Library/Formula/*.rb"].each do |f| result = `grep "# depends_on 'cmake'" "#{f}"`.strip assert_equal('', result, "Commented template code still in #{f}") end end -end
\ No newline at end of file + + def test_for_misquoted_prefix + # Prefix should not have single quotes if the system args are already separated + target_string = "[\\\"]--prefix=[\\']" + + Dir["#{HOMEBREW_PREFIX}/Library/Formula/*.rb"].each do |f| + result = `grep -e "#{target_string}" "#{f}"`.strip + assert_equal('', result, "--prefix is incorrectly single-quoted in #{f}") + end + end + +end |
