diff options
| author | Jack Nagel | 2013-04-05 22:00:36 -0500 |
|---|---|---|
| committer | Jack Nagel | 2013-04-05 22:00:36 -0500 |
| commit | 17379509ed899dfac2cb9df0736eb86458e1242a (patch) | |
| tree | 10f2f1c621892dcda606eb3cb5115a20e627957c /Library | |
| parent | 14bfaf275f6a7269c72a5f6f37f5877a2b66da67 (diff) | |
| download | homebrew-17379509ed899dfac2cb9df0736eb86458e1242a.tar.bz2 | |
Use #grep where it will suffice
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/cmd/audit.rb | 6 | ||||
| -rw-r--r-- | Library/Homebrew/cmd/doctor.rb | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index dfb0355df..afe6167b6 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -195,7 +195,7 @@ class FormulaAuditor urls = [(f.stable.url rescue nil), (f.devel.url rescue nil), (f.head.url rescue nil)].compact # Check GNU urls; doesn't apply to mirrors - urls.select { |u| u =~ %r[^(https?|ftp)://(?!alpha).+/gnu/] }.each do |u| + urls.grep(%r[^(https?|ftp)://(?!alpha).+/gnu/]).each do |u| problem "\"ftpmirror.gnu.org\" is preferred for GNU software (url is #{u})." end @@ -230,12 +230,12 @@ class FormulaAuditor end # Check for git:// GitHub repo urls, https:// is preferred. - urls.select { |u| u =~ %r[^git://([^/])*github\.com/] }.each do |u| + urls.grep(%r[^git://([^/])*github\.com/]).each do |u| problem "Use https:// URLs for accessing GitHub repositories (url is #{u})." end # Check for http:// GitHub repo urls, https:// is preferred. - urls.select { |u| u =~ %r[^http://github\.com/.*\.git$] }.each do |u| + urls.grep(%r[^http://github\.com/.*\.git$]).each do |u| problem "Use https:// URLs for accessing GitHub repositories (url is #{u})." end diff --git a/Library/Homebrew/cmd/doctor.rb b/Library/Homebrew/cmd/doctor.rb index a0ac89026..a80fd78ed 100644 --- a/Library/Homebrew/cmd/doctor.rb +++ b/Library/Homebrew/cmd/doctor.rb @@ -1095,7 +1095,7 @@ module Homebrew extend self checks = Checks.new if ARGV.include? '--list-checks' - checks.methods.select { |m| m =~ /^check_/ }.sort.each { |m| puts m } + checks.methods.grep(/^check_/).sort.each { |m| puts m } exit end @@ -1106,7 +1106,7 @@ module Homebrew extend self checks.methods.sort << "check_for_linked_keg_only_brews" << "check_for_outdated_homebrew" else ARGV.named - end.select{ |method| method =~ /^check_/ }.reverse.uniq.reverse + end.grep(/^check_/).reverse.uniq.reverse first_warning = true methods.each do |method| |
