mp3val: modernize + test added

Closes #35429.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

1 files changed, 9 insertions, 6 deletions

diff --git a/Library/Formula/mp3val.rb b/Library/Formula/mp3val.rb
index 0e2698523..b60e2fca8 100644
--- a/Library/Formula/mp3val.rb
+++ b/Library/Formula/mp3val.rb
@@ -1,12 +1,15 @@
-require 'formula'
-
 class Mp3val < Formula
-  homepage 'http://mp3val.sourceforge.net/'
-  url 'https://downloads.sourceforge.net/mp3val/mp3val-0.1.8-src.tar.gz'
-  sha1 '19f7506d387f72def2861ec271c5cb4135bd8f5e'
+  homepage "http://mp3val.sourceforge.net/"
+  url "https://downloads.sourceforge.net/mp3val/mp3val-0.1.8-src.tar.gz"
+  sha1 "19f7506d387f72def2861ec271c5cb4135bd8f5e"
 
   def install
-    system "gnumake -f Makefile.gcc"
+    system "gnumake", "-f", "Makefile.gcc"
     bin.install "mp3val.exe" => "mp3val"
   end
+
+  test do
+    mp3 = test_fixtures("test.mp3")
+    assert_match(/Done!$/, shell_output("#{bin}/mp3val -f #{mp3}"))
+  end
 end