Deprecate using symbols to define deps

1 files changed, 5 insertions, 9 deletions

diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb
index 4c726eced..ed958078f 100644
--- a/Library/Homebrew/formula.rb
+++ b/Library/Homebrew/formula.rb
@@ -492,26 +492,22 @@ EOF
       @external_deps ||= {:python => [], :perl => [], :ruby => [], :jruby => []}
 
       case name
-      when String
-        # noop
+      when String, Formula
+        @deps << name
       when Hash
         key, value = name.shift
         case value
         when :python, :perl, :ruby, :jruby
           @external_deps[value] << key
-          return
         when :optional, :recommended
-          name = key
+          @deps << key
         end
       when Symbol
-        name = name.to_s
-      when Formula
-        # noop
+        opoo "#{self.name} -- #{name}: Using symbols for deps is deprecated; use a string instead"
+        @deps << name.to_s
       else
         raise "Unsupported type #{name.class}"
       end
-
-      @deps << name
     end
 
     def skip_clean paths