diff options
| author | Mike McQuaid | 2014-02-16 22:35:14 +0000 |
|---|---|---|
| committer | Mike McQuaid | 2014-02-16 22:35:14 +0000 |
| commit | f95d5395665a1d807713dfe852de0495ea99fba3 (patch) | |
| tree | fb15f67250196e0bdd154f44f1c5b17d42156391 /Library/Homebrew | |
| parent | 870fb3431652214e3f02f73f86be428fba5454ad (diff) | |
| download | homebrew-f95d5395665a1d807713dfe852de0495ea99fba3.tar.bz2 | |
audit: handle recommended/optional options better.
Diffstat (limited to 'Library/Homebrew')
| -rw-r--r-- | Library/Homebrew/cmd/audit.rb | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 48f1d6620..4c44de2c1 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -143,8 +143,14 @@ class FormulaAuditor end dep.options.reject do |opt| - # TODO -- fix for :recommended, should still allow --with-xyz - dep_f.build.has_option?(opt.name) + next true if dep_f.build.has_option?(opt.name) + dep_f.requirements.detect do |r| + if r.tags.include? :recommended + opt.name == "with-#{r.name}" + elsif r.tags.include? :optional + opt.name == "without-#{r.name}" + end + end end.each do |opt| problem "Dependency #{dep} does not define option #{opt.name.inspect}" end |
